KeyVault Keys Readme and Samples issues

[Melanie-Ma]

Section Link:

Reason:

Suggestion:

.vaultUrl("https://myvault.azure.net/")
.credential(new DefaultAzureCredentialBuilder().build())
.httpLogOptions(new HttpLogOptions().setLogLevel(HttpLogDetailLevel.BODY_AND_HEADERS))
.httpClient(HttpClient.createDefault())
.buildAsyncClient();

Section Link:

Suggestion:
Update client key to client secret.
3.
Section Link:

Reason:
Click on 'Encrypt Asynchronously' is unresponsive.

Suggestion:
It's should jump to the link: https://github.com/Azure/azure-sdk-for-java/tree/azure-security-keyvault-keys_4.1.4/sdk/keyvault/azure-security-keyvault-keys#encrypt-asynchronously

[Melanie-Ma]

@jongio , for notification.

[joshfree]

@vcolin7 PTAL

[vcolin7]

1. I tested the suggested code and it didn't work for me. The correct code would need to remove the addPolicy() line and keep the call to credential():

   .vaultUrl("https://myvault.azure.net/")
   .credential(new DefaultAzureCredentialBuilder().build())
   .httpLogOptions(new HttpLogOptions().setLogLevel(HttpLogDetailLevel.BODY_AND_HEADERS))
   .httpClient(HttpClient.createDefault())
   .buildAsyncClient();

   Since the given Credential object will be added to the pipeline in a KeyVaultCredentialPolicy by the Builder.

2. Agreed.

3. Agreed.

[vcolin7]

The same issue from point number 2 is also present in the Certificates README but both have already been corrected in master.