The From property is not used and not defined in the MSDN docs for query. It should be removed.
gchengrepo collab
an hour ago
MSDN documentation says it supports select and filter, with no specificity about whether from is supported or not. Even if it doesn't support right now, leaving it in sdk may still be valuable for future scenarios.
http://msdn.microsoft.com/en-us/library/windowsazure/dd179421.aspx
jcookemsrepo collab
43 minutes ago
I disagree; no code in the SDK is using that property, so it is misleading to keep it in a class where it is implied to be an option, and it is bad practice to have dead code. If we need to, we can add it later.
gchengrepo collab
39 minutes ago
This is an interesting perspective, what about orderby and other properties? My point is that we should be consistent, if we delete from, we should delete others as well. Thoughts?
ogail
4 minutes ago
I understand both of your point of views and for that, I suggest to leave this function with private modifier. By doing this we are not exposing something that's not working and at same time we can turn it to public when they are supported.
The From property is not used and not defined in the MSDN docs for query. It should be removed.
gchengrepo collab
an hour ago
MSDN documentation says it supports select and filter, with no specificity about whether from is supported or not. Even if it doesn't support right now, leaving it in sdk may still be valuable for future scenarios.
http://msdn.microsoft.com/en-us/library/windowsazure/dd179421.aspx
jcookemsrepo collab
43 minutes ago
I disagree; no code in the SDK is using that property, so it is misleading to keep it in a class where it is implied to be an option, and it is bad practice to have dead code. If we need to, we can add it later.
gchengrepo collab
39 minutes ago
This is an interesting perspective, what about orderby and other properties? My point is that we should be consistent, if we delete from, we should delete others as well. Thoughts?
ogail
4 minutes ago
I understand both of your point of views and for that, I suggest to leave this function with private modifier. By doing this we are not exposing something that's not working and at same time we can turn it to public when they are supported.