[Ready for review] Graph & Key Vault MGMT

[jianghaolu]

No description provided.

[azurecla]

Hi @jianghaolu, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

[azuresdkci]

Runtime changes detected. pull request created. CI running:

[jianghaolu]

@martinsawicki
This will show a diff without generated files: 0484ce6...93be0f4

[martinsawicki]

hmm, that view doesn't let me add comments..

[martinsawicki]

In general, from my quick look, the following 3 key things caught my eye:

• What is called "Group" should probably better be called "ActiveDirectoryGroup" (based on the naming of ADGroupInner)
• Replace Boolean returning methods with boolean
• Javadoc's @return should start with a small letter and no period
  After the PR, i'll try to play with in in code to see if I'd have more comments.
  I noticed some interesting uses of base interfaces to reuse teh same definition in different contexts - i'll play with that and see if we can reuse taht pattern in other places (does it really avoid raw type refs? It';d be great if it did, without the duplication)

[martinsawicki]

also, no period at the end for @return :-)

[jianghaolu]

Thanks! Good catches. I'll fix them.

Two things to notice:

1. The Azure.authenticate() signature is changed
2. Graph is in fact in progress. E.g.: Group doesn't have an impl yet. I'll add them in the Graph PR.