[Ready For Review] Virtual machine scale sets by anuchandy · Pull Request #1071 · Azure/azure-sdk-for-java

anuchandy · 2016-09-13T19:41:16Z

No description provided.

…the primary load balancers

…he ipconfig

… and nat pools

…s during update

azuresdkci · 2016-09-13T19:45:40Z

Can one of the admins verify this patch?

azuresdkci · 2016-09-13T19:46:21Z

Runtime changes detected. pull request created. CI running:

…s-fluent2

…ing VMSS in an invalid state (bug in crp)

…s-fluent2

…et facing load balancer

…s-fluent2

martinsawicki · 2016-09-18T19:45:22Z

+         * virtual machine's primary network interface in the scale set.
+         *
+         */
+        interface WithSubnet {


instead of selecting the network first and then the subnet name, you could just do in in one call: see Frontend's withExistingSubnet

sounds good, will do

martinsawicki · 2016-09-18T19:52:22Z

+         * The stage of a virtual machine scale set update containing inputs for the resource to be updated
+         * (via {@link WithApplicable#apply()}).
+         */
+        interface WithApplicable extends


Not sure about WithApplicable as the naming here - i think what was meant was WithApply
But i'm also wondering why this interface is needed - i just point have optional methods return Update

Right, i mean WithApply.

The reason for this interface is - i want to maintain a context in the initial stages of update. i.e. during update i want show withInternal|internetFacingLoadBalancer and if user choose it then give him an option to specify the backends and natpool from the load balancer.

martinsawicki · 2016-09-18T19:56:36Z

+    }
+
+    @Override
+    public VirtualMachineScaleSetImpl disableVmAgent() {


the naming convention we generally follow for these, especially at the top level resource, is to start with 'with' to help with the disoverability. So the consistent and intuitive naming here would simply be withVmAgent()/withoutVmAgent()

martinsawicki · 2016-09-18T19:58:05Z

+    }
+
+    @Override
+    public VirtualMachineScaleSetImpl disableAutoUpdate() {


along similar lines to the previous comment, couldn't this be simply withAutoUpdate()/withoutAutoUpdate()?

will fix them.

martinsawicki · 2016-09-18T20:17:28Z

+    // Actions
+    //
+    /**
+     * @return  available skus for the virtual machine scale set including the minimum and maximum vm instances


Javadoc convention: no period at the end of the @return and other such parts. Only the description uses proper casing and periods, because those are intended to be full sentences.

will fix all, thanks

anuchandy · 2016-09-19T23:33:08Z

@martinsawicki please take a look, addressed your comments, thanks!

…s-fluent2

hovsepm · 2016-09-21T01:25:24Z

@azuresdkci retest this please

martinsawicki · 2016-09-21T16:14:12Z

+     *
+     * @throws IOException the IO exception
+     */
+    Map<String, Backend> primaryInternetFacingLoadBalancerBackEnds() throws IOException;


it's Backend not BackEnds

martinsawicki · 2016-09-21T16:14:30Z

+     *
+     * @throws IOException the IO exception
+     */
+    Map<String, Backend> primaryInternetFacingLoadBalancerBackEnds() throws IOException;


it's Backends not BackEnds

martinsawicki · 2016-09-21T16:15:14Z

+     *
+     * @throws IOException the IO exception
+     */
+    Map<String, Backend> primaryInternalLoadBalancerBackEnds() throws IOException;


Backends not BackEnds

martinsawicki · 2016-09-21T16:16:38Z

+        }
+
+        /**
+         * The stage of the virtual machine scale set definition allowing to specify Sku for the virtual machines.


"specify Sku" --> "specify the SKU" (it's an acronym)

martinsawicki · 2016-09-21T16:17:10Z

+         */
+        interface WithSku {
+            /**
+             * Specifies sku for the virtual machines in the scale set.


"Specifies the SKU ..."

martinsawicki · 2016-09-21T16:17:35Z

+            WithNetworkSubnet withSku(VirtualMachineScaleSetSkuTypes skuType);
+
+            /**
+             * Specifies sku for the virtual machines in the scale set.


"Specifies the SKU..."

martinsawicki · 2016-09-21T16:18:54Z

+
+        /**
+         * The stage of the virtual machine scale set definition allowing to specify a public load balancer for
+         * the primary network interface of the scale set virtual machines.


may be cleaner to say "[...] for the primary network interfaces of the virtual machines in the scale set."

martinsawicki · 2016-09-21T16:20:20Z

+         */
+        interface WithPrimaryInternetFacingLoadBalancer {
+            /**
+             * Specify the public load balancer where it's backends and/or NAT pools can be assigned to the primary network


maybe better: "Specify the Internet-facing load balancer whose backends and/or NAT pools can be assigned to the primary network interfaces of the virtual machines in the scale set."

martinsawicki · 2016-09-21T16:21:56Z

+     * in the scale set.
+     * <p>
+     * A primary internal load balancer associated with the primary network interfaces of the scale set
+     * virtual machine will be also belongs to this network


typo: "belong" not "belongs"

martinsawicki · 2016-09-21T16:22:26Z

+    Network primaryNetwork() throws IOException;
+
+    /**
+     * @return the internet facing load balancer associated with the primary network interface of


should be "Internet-facing"

martinsawicki · 2016-09-21T16:22:55Z

+    LoadBalancer primaryInternetFacingLoadBalancer() throws IOException;
+
+    /**
+     * @return the internet facing load balancer's backends associated with the primary network interface


"Internet-facing"

martinsawicki · 2016-09-21T16:23:52Z

+    Map<String, Backend> primaryInternetFacingLoadBalancerBackEnds() throws IOException;
+
+    /**
+     * @return the internet facing load balancer's inbound NAT pool associated with the primary network interface


"Internet-facing".
I won't comment on these anymore -- it'd be good to just search/replace "internet facing" with "Internet-facing"

martinsawicki · 2016-09-21T16:25:04Z

+    Map<String, InboundNatPool> primaryInternalLoadBalancerInboundNatPools() throws IOException;
+
+    /**
+     * @return the list of ids of public Ip addresses associated with the primary internet facing load balancer


"the list of IDs of the public IP addresses [...]"

martinsawicki · 2016-09-21T16:25:42Z

+    List<String> primaryPublicIpAddressIds() throws IOException;
+
+    /**
+     * @return the url to storage containers that stores vhds of virtual machines in the scale set


"URL" and "store"

martinsawicki · 2016-09-21T16:26:25Z

+    VirtualMachineScaleSetNetworkProfile networkProfile();
+
+    /**
+     * @return the extensions attached to the Virtual Machines in the scale set


"virtual machines" (capitalization)

martinsawicki · 2016-09-21T16:27:49Z

+            /**
+             * Specifies sku for the virtual machines in the scale set.
+             *
+             * @param sku a sku from the list of available sizes for the virtual machines in this scale set


" a SKU". Let's just search/replace all "sku" with "SKU" in javadocs (not code)

martinsawicki · 2016-09-21T16:28:25Z

+        }
+
+        /**
+         * The stage of the virtual machine scale set definition allowing to specify virtual network subnet for the


"the virtual network subnet"

martinsawicki · 2016-09-21T16:29:42Z

+             * Specify the public load balancer where it's backends and/or NAT pools can be assigned to the primary network
+             * interface of the scale set virtual machines.
+             * <p>
+             * By default all the backend and inbound NAT pool of the load balancer will be associated with the primary


"backends and inbound NAT pools"

martinsawicki · 2016-09-21T16:30:18Z

+            WithPrimaryInternetFacingLoadBalancerBackendOrNatPool withPrimaryInternetFacingLoadBalancer(LoadBalancer loadBalancer);
+
+            /**
+             * Specifies that no public load balancer needs to be associated with virtual machine scale set.


"[...] with the virtual machine scale set."

martinsawicki · 2016-09-21T16:30:58Z

+
+        /**
+         * The stage of the virtual machine scale set definition allowing to specify an internal load balancer for
+         * the primary network interface of the scale set virtual machines.


maybe cleaner: "[...] of the virtual machines in the scale set."

martinsawicki · 2016-09-21T16:31:24Z

+         */
+        interface WithPrimaryInternalLoadBalancer {
+            /**
+             * Specify the internal load balancer where it's backends and/or NAT pools can be assigned to the primary network


"its" not "it's"

martinsawicki

overall, i just focused more on the Javadoc content, but it looks like it will be more efficient to just do a big Javadoc scrub across the entire SDK's API surface, as there are a number of stylistic conventions that are appropriate, so my Javadoc input is not the highest pri.

merging since code review has been addressed. there are just some naming corrections (Backend not BackEnd) which we can followup up with aftet the merge, but the javadoc scrub will need to happen as a more focused effort.

anuchandy added 14 commits September 9, 2016 18:50

VirtualMachineScaleSet interface with defintion and update stages of …

2b7d733

…the primary load balancers

Adding more intermediate stage interfaces to update stages

68bd2f7

Adding more definition stages of virtual machine scale set

1539d2e

Initial VirtualMachineScaleSetImpl and Sku models

0596d03

Enabling wither for load balancer & it's backends and nat pools

5d750dc

Logic to add & remove backend and inbound nat pool association with t…

b4f3018

…he ipconfig

Adding support for virtual machine scale set extensions

ffa0139

Adding scale sets entry point

9641f2e

using lb state variables on update

527b1e6

implementing createInner

607688c

Adding withers to set computer name prefix and to remove the backends…

5c5cfc9

… and nat pools

Exposing some actions

8b49955

Adding actions to vmss collction and enabling replacing load balancer…

e819bd9

…s during update

Merge remote-tracking branch 'origin/master' into vmss-fluent2

d0a921c

azurecla added the cla-not-required label Sep 13, 2016

azuresdkci mentioned this pull request Sep 13, 2016

[Automatic PR] SDK changes from pull request #1071 Azure/autorest-clientruntime-for-java#63

Closed

anuchandy added 8 commits September 13, 2016 15:51

Starting unit test and some fixes

dd48691

Merge branch 'master' of github.com:Azure/azure-sdk-for-java into vms…

520ae9e

…s-fluent2

setting couple of default values and simplifying code

b4c249c

first unit test that creates VMSS. Adding a check to avoid Azure putt…

8353c4a

…ing VMSS in an invalid state (bug in crp)

Merge branch 'master' of github.com:Azure/azure-sdk-for-java into vms…

e100f6c

…s-fluent2

fix checkstyle error due to incorrect javadoc

d7b1241

Adding unit test validate connection to vms in a scale set via intern…

64d4056

…et facing load balancer

Merge branch 'master' of github.com:Azure/azure-sdk-for-java into vms…

fb53fc1

…s-fluent2

anuchandy changed the title ~~[In Progress] Virtual machine scale sets~~ [Ready For Review] Virtual machine scale sets Sep 17, 2016

Using updated ChildResource that exposes parent()

5be9ab4

martinsawicki suggested changes Sep 18, 2016

View reviewed changes

Addressing CR and adding annotations

fe9b75d

martinsawicki approved these changes Sep 20, 2016

View reviewed changes

Merge branch 'master' of github.com:Azure/azure-sdk-for-java into vms…

357b8bb

…s-fluent2

martinsawicki reviewed Sep 21, 2016

View reviewed changes

martinsawicki merged commit 0b98bc5 into Azure:master Sep 21, 2016

anuchandy mentioned this pull request Sep 22, 2016

[Ready for Review] Addressing vmss::javadoc review comments #1096

Merged

anuchandy deleted the vmss-fluent2 branch February 8, 2017 23:46

Uh oh!

Conversation

anuchandy commented Sep 13, 2016

Uh oh!

azuresdkci commented Sep 13, 2016

Uh oh!

azuresdkci commented Sep 13, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anuchandy commented Sep 19, 2016

Uh oh!

hovsepm commented Sep 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

martinsawicki left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone