A bit of clean up in graph#1081
Conversation
|
Creation doesnt work yet. Just a bit of clean up before the C# conversion. |
|
Runtime changes detected. pull request created. CI running: |
anudeepsharma
left a comment
anudeepsharma
left a comment
There was a problem hiding this comment.
Approved with a minor change.
| List<User> userList = graphRbacManager.users().list(); | ||
| Assert.assertNotNull(userList); | ||
| User user = graphRbacManager.users().define("jeffrolfnlu@hotmail.com") | ||
| User user = graphRbacManager.users().define("azuresdk@outlook.com") |
There was a problem hiding this comment.
Can we delete this user after test is done? not sure if we can do so. But this test is not doing much once it run for first time as this user will always be there for ever.
There was a problem hiding this comment.
This test is not functional. For now it's just a placeholder.
| @Override | ||
| public Observable<ServicePrincipal> createResourceAsync() { | ||
| return null; | ||
| throw new UnsupportedOperationException("Will be implemented in a next release"); |
There was a problem hiding this comment.
instead of promising when it will be implemented, which we probably shouldn't do, we could just say "Not yet implemented".
There was a problem hiding this comment.
It will be done in a few days. So I'm lying anyways.
There was a problem hiding this comment.
ah, ok. Well, but if a bus runs you over in the meantime (which I hope it doesn't!) there is a chance we'll ship it as is, so...
There was a problem hiding this comment.
Fix it, not sure why the new Github doesn't hide this
A bit of clean up in graph
5 participants
No description provided.