Skip to content

Adding api annotations to graph and keyvault#1091

Merged
martinsawicki merged 1 commit into
Azure:masterfrom
jianghaolu:langdef
Sep 23, 2016
Merged

Adding api annotations to graph and keyvault#1091
martinsawicki merged 1 commit into
Azure:masterfrom
jianghaolu:langdef

Conversation

@jianghaolu

Copy link
Copy Markdown
Contributor

No description provided.

@azuresdkci

Copy link
Copy Markdown
Contributor

Runtime changes detected. pull request created. CI running: Build Status

@martinsawicki martinsawicki left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to change from @LandDefinition(...) to @fluent() at the top level, and remove all other LangDefinition annotationms from nested interfaces. The empty @fluent at the top should be sufficient.

/**
* An immutable client-side representation of an Azure AD group.
*/
@LangDefinition

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note we now have a simplified annotations approach: just use @fluent() at the top interface and nothing else is needed. The embedded interfaces will be processed automatically - no need to annotate them (per Alva).
The LangDefinition imports can simply be all removed.

@martinsawicki martinsawicki merged commit d4748b8 into Azure:master Sep 23, 2016
@jianghaolu

Copy link
Copy Markdown
Contributor Author

Oops? I haven't converted the annotations.

jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
Fixing PagedList and adding unit test for ResourcePagedList
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
i'll deal with the annotation updates as part of my overall scrub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants