[#1078] Add async delete support#1102
Merged
Merged
Conversation
Contributor
|
Runtime changes detected. pull request created. CI running: |
anuchandy
approved these changes
Sep 24, 2016
anuchandy
left a comment
anuchandy
left a comment
Member
There was a problem hiding this comment.
LGTM.. left one comment, pls take a look
| } | ||
| }), callback); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
@Override
public abstract Observable<Void> deleteAsync(string id);is it cleaner if we add this here?
| @Override | ||
| public Observable<Void> deleteAsync(String id) { | ||
| return deleteAsync(ResourceUtils.groupFromResourceId(id), ResourceUtils.nameFromResourceId(id)); | ||
| } |
Member
There was a problem hiding this comment.
same as previous comment..
@Override
public abstract Observable<Void> deleteAsync(string groupName, string name);
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
per Anu's review, ok to merge -- comments could be addressed separately and are not blocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1078