Implemented ORS List Blobs#11756
Conversation
| this.objectReplicationSourcePolicies = null; | ||
| if (blobItemInternal.getObjectReplicationMetadata() != null) { | ||
| this.objectReplicationSourcePolicies = new HashMap<>(); | ||
| for (String orString : blobItemInternal.getObjectReplicationMetadata().keySet()) { |
There was a problem hiding this comment.
I think CI will tell you this, but we should use entrySet instead of keySet so we don't have to index into the map
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft and
sima-zhu
as code owners
alzimmermsft
left a comment
alzimmermsft
left a comment
There was a problem hiding this comment.
Do we need to add another parameter to the BlobRequestConditions model for ifTags? There will need to be a Swagger transform to remove the following from the $.parameters.IfTags.
"x-ms-parameter-grouping": {
"name": "modified-access-conditions"
},| String ifTags = null; | ||
| if (modifiedAccessConditions != null) { | ||
| ifTags = modifiedAccessConditions.getIfTags(); | ||
| } |
There was a problem hiding this comment.
Do we need to add another property to the BlobRequestConditions class?
There was a problem hiding this comment.
This ifTags generated code stuff wasnt meant to be part of this PR but someone had already changed swagger so I havent implemented it yet. That will come in a future PR.
Bute you're right, I think we need to remove the grouping and add it to BlobRequestCondiitons like the other params.
There was a problem hiding this comment.
For this PR, we want to just focus on the listBlobs changes
kasobol-msft
left a comment
kasobol-msft
left a comment
There was a problem hiding this comment.
- Please sync data model with Azure/azure-sdk-for-net#12740
- Please hold with merge until current STG73 branch ships. So we don't creep APIViews.
| if (blobItemInternal.getObjectReplicationMetadata() != null) { | ||
| this.objectReplicationSourcePolicies = new HashMap<>(); | ||
| for (Map.Entry<String, String> p : blobItemInternal.getObjectReplicationMetadata().entrySet()) { | ||
| String orString = p.getKey(); | ||
| String str = orString.startsWith("or-") ? orString.substring(3) : orString; | ||
| String[] split = str.split("_"); | ||
| String policyId = split[0]; | ||
| String ruleId = split[1]; | ||
| if (objectReplicationSourcePolicies.containsKey(policyId)) { | ||
| objectReplicationSourcePolicies.get(policyId) | ||
| .putRuleAndStatus(ruleId, p.getValue()); | ||
| } else { | ||
| ObjectReplicationPolicy policy = new ObjectReplicationPolicy(policyId); | ||
| policy.putRuleAndStatus(ruleId, p.getValue()); | ||
| objectReplicationSourcePolicies.put(policyId, policy); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This needs to find new home. We need to decouple model from "implementation model" per APIView feedback.
Anyway, it's a good practice to NOT place such logic inside constructors. BlobItem should ideally be plain data structure and this logic should move to some "transformer/mapper".
4 participants
No description provided.