Separate ListingByTag into group & subscription level#1202
Merged
Conversation
anudeepsharma
approved these changes
Oct 18, 2016
anudeepsharma
left a comment
anudeepsharma
left a comment
Contributor
There was a problem hiding this comment.
Approving with changes.
| public PagedList<ResourceGroup> listByTag(String tagName, String tagValue) { | ||
| if (tagName == null) { | ||
| throw new IllegalArgumentException("tagName == null"); | ||
| } |
Contributor
There was a problem hiding this comment.
As you are splitting the code for listing at subscription and at resource group, I assume generating ODataFilter is common code at both locations. If that is the case can you create a utility to create the ODataFilter string.
martinsawicki
approved these changes
Oct 19, 2016
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
Separate ListingByTag into group & subscription level
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-for-java
that referenced
this pull request
Mar 21, 2019
* Added a check to make sure the property.documentation doesn't already start with Gets before appending it as a prefix * Regenerated CSharp tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.