Skip to content

Rename delete to deleteByBlah to align with getByBlahs#1236

Merged
martinsawicki merged 4 commits into
Azure:masterfrom
jianghaolu:deleteby
Oct 25, 2016
Merged

Rename delete to deleteByBlah to align with getByBlahs#1236
martinsawicki merged 4 commits into
Azure:masterfrom
jianghaolu:deleteby

Conversation

@jianghaolu

@jianghaolu jianghaolu commented Oct 25, 2016

Copy link
Copy Markdown
Contributor

This is a continuation of #1235.

API breakages:

  • collections().delete(String id) -> collections().deleteById(String id)
  • resourceGroups().delete(String id) -> resourceGroups().deleteByName(String name)
  • collections().delete(String groupName, String name) -> collections().deleteByGroup(String groupName, String name)

@martinsawicki

Copy link
Copy Markdown

does this introduce breaking changes from beta3?
If so, pls use the compat-breaks tag and list the exact API changes in the PR comments.
For example, see: #1140

@martinsawicki martinsawicki merged commit 560aa18 into Azure:master Oct 25, 2016
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
Rename delete to deleteByBlah to align with getByBlahs
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this pull request Mar 21, 2019
…nge is related to PR Azure#1011 where generalized method was introduced. (Azure#1236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants