Skip to content

resourcemanager support keyvault to list properties of disabled secrets #13596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xseeseesee merged 1 commit into from
Jul 29, 2020
Merged

resourcemanager support keyvault to list properties of disabled secrets #13596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...-keyvault/src/main/java/com/azure/resourcemanager/keyvault/implementation/SecretImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,13 @@ public Flux<Secret> listVersionsAsync() {
return vault
.secretClient()
.listPropertiesOfSecretVersions(name())
.flatMap(p -> vault.secretClient().getSecret(p.getName(), p.getVersion()))
.flatMap(p -> {
if (p.isEnabled()) {
return vault.secretClient().getSecret(p.getName(), p.getVersion());
} else {
return Mono.just(new KeyVaultSecret(p.getName(), null).setProperties(p));
}
})
.map(this::wrapModel);
}

Expand Down
8 changes: 7 additions & 1 deletion ...keyvault/src/main/java/com/azure/resourcemanager/keyvault/implementation/SecretsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,13 @@ public PagedFlux<Secret> listAsync() {
return PagedConverter
.flatMapPage(
inner.listPropertiesOfSecrets(),
s -> vault.secretClient().getSecret(s.getName(), s.getVersion()).map(this::wrapModel));
s -> {
if (s.isEnabled()) {
return vault.secretClient().getSecret(s.getName(), s.getVersion()).map(this::wrapModel);
} else {
return Mono.just(wrapModel(new KeyVaultSecret(s.getName(), null).setProperties(s)));
}
});
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion ...ourcemanager-keyvault/src/main/java/com/azure/resourcemanager/keyvault/models/Secret.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
/** An immutable client-side representation of an Azure Key Vault secret. */
@Fluent
public interface Secret extends Indexable, HasInner<KeyVaultSecret>, HasId, HasName, Updatable<Secret.Update> {
/** @return the secret value */
/** @return the secret value when the secret is enabled */
String value();

/** @return the secret management attributes */
Expand Down