Mgmt add samples package#13770
Merged
ChenTanyi merged 31 commits intoAug 6, 2020
Merged
Conversation
ChenTanyi
requested review from
JimSuplizio,
JonathanGiles,
anuchandy,
danieljurek,
hemanttanwar,
joshfree,
mitchdenny,
srnagar,
weidongxu-microsoft,
weshaggard,
xseeseesee and
yungezz
as code owners
August 4, 2020 06:22
Comment on lines
+11
to
+21
| ### Adding the package to your product | ||
|
|
||
| [//]: # ({x-version-update-start;com.azure.resourcemanager:azure-resourcemanager;current}) | ||
| ```xml | ||
| <dependency> | ||
| <groupId>com.azure.resourcemanager</groupId> | ||
| <artifactId>azure-resourcemanager</artifactId> | ||
| <version>2.0.0-beta.4</version> | ||
| </dependency> | ||
| ``` | ||
| [//]: # ({x-version-update-end}) |
Member
There was a problem hiding this comment.
This part seems not correct?
Actually the whole readme seems not correct. Do we really need to add it now?
Contributor
Author
There was a problem hiding this comment.
I think sample version will just follow with azure, so I use the azure version rather than create a new version. Due to sample will not release.
Member
There was a problem hiding this comment.
OK. I just feel the readme is not correct at all, starting from the title...
Contributor
Author
There was a problem hiding this comment.
Title could change. Is it any format required for the title?
Member
There was a problem hiding this comment.
+1, this is auto-generated right? maybe need a manual overview readme
Contributor
Author
There was a problem hiding this comment.
Title changed, package and version remain to azure.
Contributor
Author
There was a problem hiding this comment.
@yungezz Not auto-gen, it is just a manual copy. Due to CI requirement.
weidongxu-microsoft
approved these changes
Aug 5, 2020
xseeseesee
approved these changes
Aug 5, 2020
ChenTanyi
requested review from
David-Noble-at-work,
alzimmermsft,
amishra-dev,
gapra-msft,
jaschrep-msft,
kirankumarkolli,
kushagraThapar,
mbhaskar,
moderakh,
rickle-msft and
sima-zhu
as code owners
August 5, 2020 07:29
ChenTanyi
added a commit
that referenced
this pull request
Aug 7, 2020
* Move azure-resourcemanager to sdk/resourcemanager (#13225) * Move azure-resourcemanager library. * Add entry to ci.yml * Fix groupId. * Move management packages. * Remove module references from parent. * Fix typo in pom. * Tweak versions. * Fix invalid version in POM. * Fix dependency versions. * Add empty changelogs. * Add groupId and version tags. * Centralize versioning for resource manager libraries (#13341) * centralize versioning for resource manager libraries * add missing tag to azure-resourcemanager-resources/pom.xml * Set low min coverage and add RM libs to Jacoco * Move container instance to resourcemanager (#13475) * move container instance after merge * update versioning for aci * update resourcemanager dependency version * add container instance in ci and pom * update azure-resourcemanger dependency * add changelog and readme * update azure-identity version * update revapi to suppress external API in resource manager (#13476) * add code owner for resource manager (#13513) * add code owner for resource manager * remove code owner for management * remove maven preperties for test base (#13514) * Mgmt fix resources warning (#13512) * remove deprecation and compiler args * fix DAG node warning * fix top level resource error * suppress all uncheck cast from parent to children * fix task group to array warning * suppress heap pollution warning * Revert "fix task group to array warning" This reverts commit 0589215. * Revert "fix top level resource error" This reverts commit ae6a705. * suppress rawtypes rather than change * resourcemanager upgrade resouces to package-resources-2020-06 (#13560) * add required scripts * update api-specs.json * upgrade resources * generate package-resources-2020-06 * fix compile errors and add outoutResources/provisioningOperation * update session records * Fix warning (#13571) * remove optional and resource plugin * fix some rbac type warning * suppress unchecked and rawtypes * suppress compute warning * fix app service warning * fix cosmos warning * fix aks warning * fix monitor warning * change msi handler to generic type rather than suppress rawtypes * change ExpressRouteCircuitPeering to generic type * Fix generic type warning (#13572) * fix rbac return warning * fix monitor warning * resourcemanager upgrade network to package-2020-05 (#13591) * upgrade network to package-2020-05 * generate package-2020-05 * fix checkstyle * update session records * update after running credcheck * fix npe (#13590) * resourcemanager support keyvault to list properties of disabled secrets (#13596) * Fix resource manager test (#13642) * change template type name * remove compiler plugin * fix record session * exclude fluent and models in Jacoco, due to they are generated or interface * format all pom * decrease acr test coverage * fix checkstyle * fix dns test due to fail in mac many times (#13661) * fix dns test due to fail in mac many times * fix for-loop * skip non management exception * remove management exception count due to not stable (#13677) * Mgmt Refine pom (#13776) * change azure package name with management * update javadoc * remove azure-resourcemanager-parent * update cred check script (#13806) * Mgmt add samples package (#13770) * move samples * format pom * update pom * add banned dependency * fix cosmos client * remove authorityHost for DefaultAzureCredentialBuilder * fix compile error * fix sample warning * catch request exception * change resource group delete to begin delete * update session records * remove non ascii char * override build resources in samples due to resources error * remove account key * remove resourcemanager_com.google.guava:guava * fix storage pom * fix checkstyle * add java 11 override resource too * remove jacoco exclude due to sample satisfy coverage * update sample readme title, pacakge and version remain to azure * add samples version in pom for CI * update sample readme according to CI * skipOutput get from configuration * add variables in ci * ship output by default * test storage and cosmos ci * Revert "test storage and cosmos ci" This reverts commit fd4b281. * add additional projects * skip jacoco in samples * exclude false positive spotbugs * add storage additional module * remove resourcemanager_org.apache.httpcomponents:httpclient version * update dependency version * update additional modules * add module * update version Co-authored-by: Mitch Denny <midenn@microsoft.com> Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: Chuang <54572251+xccc-msft@users.noreply.github.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.