API ServiceBusErrorSource to represent source of error#16710
Merged
Conversation
ghost
added
the
conniey
reviewed
Oct 23, 2020
added 7 commits
October 26, 2020 15:53
hemanttanwar
marked this pull request as ready for review
October 27, 2020 08:20
hemanttanwar
commented
Oct 27, 2020
conniey
reviewed
Oct 27, 2020
conniey
reviewed
Oct 27, 2020
conniey
reviewed
Oct 27, 2020
srnagar
reviewed
Oct 28, 2020
srnagar
reviewed
Oct 29, 2020
| .verifyErrorMatches(throwable -> { | ||
| Assertions.assertTrue(throwable instanceof ServiceBusAmqpException); | ||
| final ServiceBusErrorSource actual = ((ServiceBusAmqpException) throwable).getErrorSource(); | ||
| Assertions.assertEquals(ServiceBusErrorSource.RECEIVE, actual); |
Member
There was a problem hiding this comment.
Can we also have tests for error source UNKNOWN?
conniey
reviewed
Oct 29, 2020
conniey
reviewed
Oct 29, 2020
conniey
requested changes
Oct 29, 2020
srnagar
reviewed
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce ServiceBusErrorSource, to help user identify source of the error. Specially in error handler in processor model.
/**
*/
public enum ServiceBusErrorSource {
SEND,
RECEIVE,
APPEND,
COMPLETE,
DEFER,
DEAD_LETTER,
PEEK;
}
Also removing unwanted opens statements from module info as they are not needed.