End to End TLS SSL step #3#16773
Merged
Merged
Conversation
mnriem
requested review from
backwind1233,
chenrujun,
g2vinay,
jialindai,
samvaity,
saragluna,
vcolin7 and
yiliuTo
as code owners
ghost
added
the
vcolin7
reviewed
Oct 25, 2020
vcolin7
left a comment
vcolin7
left a comment
Member
There was a problem hiding this comment.
Most things look good to me. I think it would be very helpful if these PRs had a brief description of what changes were made to look out for them, especially when there's another unmerged PR this is based on.
| String clientId = System.getProperty("azure.keyvault.clientId"); | ||
| String clientSecret = System.getProperty("azure.keyvault.clientSecret"); | ||
| keyVault = new KeyVaultClient(keyVaultUri, tenantId, clientId, clientSecret); | ||
| keyVaultClient = new KeyVaultClient(keyVaultUri, tenantId, clientId, clientSecret); |
Member
There was a problem hiding this comment.
Suggested change
| keyVaultClient = new KeyVaultClient(keyVaultUri, tenantId, clientId, clientSecret); | |
| keyVaultClient = new KeyVaultClient(keyVaultUrl, tenantId, clientId, clientSecret); |
All occurrences, really :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.