Skip to content

[TA] CodeGen based on 3.1-preview.3#17177

Closed
mssfang wants to merge 2 commits into
Azure:masterfrom
mssfang:TA-swagger3_1Preview3
Closed

[TA] CodeGen based on 3.1-preview.3#17177
mssfang wants to merge 2 commits into
Azure:masterfrom
mssfang:TA-swagger3_1Preview3

Conversation

@mssfang

@mssfang mssfang commented Nov 4, 2020

Copy link
Copy Markdown
Contributor

@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics labels Nov 4, 2020
@mssfang mssfang added this to the [2020] November milestone Nov 4, 2020
@mssfang mssfang self-assigned this Nov 4, 2020
@mssfang
mssfang requested review from abhahn and iscai-msft November 4, 2020 21:04
import com.azure.ai.textanalytics.implementation.models.DocumentError;
import com.azure.ai.textanalytics.implementation.models.EntitiesResult;
import com.azure.ai.textanalytics.implementation.models.MultiLanguageBatchInput;
import com.azure.ai.textanalytics.implementation.models.PiiEntitiesResult;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service renamed it to PiiResult

* model.
*/
@Fluent
public class Components15Gvwi3SchemasTasksstatePropertiesTasksPropertiesEntityrecognitiontasksItemsAllof1 {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of this class is messed up?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Autogenerated.
I think it can be removed. Want a confirm from @suhas92

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those classes are duplicate classes. Somehow the autogene/swagger mess these up. I removed them already.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually removed?
If yes, we should check with the autorest crew on this and not do manual updates to generated code.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is the swagger issue. I think it is safe to remove since they are useless.

* model.
*/
@Fluent
public class Components15X8E9LSchemasTasksstatePropertiesTasksPropertiesEntityrecognitionpiitasksItemsAllof1 {

@samvaity samvaity Nov 4, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.
Are other langs seeing this too?

cc: @maririos @iscai-msft

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

talked offline with @suhas92, .NET has the same issue. it is from the swagger. I remove these 3 classes right now, since these class are exactly same as TasksStateTasksEntityRecognitionTasksItem, etc.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add these classes back once it is fixed. Currently, there is not usage of these classes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the swagger issue is tracked and resolved.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Suhas has it on the issue tracker.

@mssfang
mssfang requested a review from samvaity November 4, 2020 22:12
@mssfang

mssfang commented Nov 4, 2020

Copy link
Copy Markdown
Contributor Author

Create a feature branch to have all v3.1-preview.3 changes.
#17182

@mssfang mssfang closed this Nov 4, 2020
@mssfang
mssfang deleted the TA-swagger3_1Preview3 branch November 4, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants