Skip to content

[Perf] Fail fast on unhandled exceptions in Reactor threads #21690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeharder merged 2 commits into from
May 20, 2021
Merged

[Perf] Fail fast on unhandled exceptions in Reactor threads #21690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4386a7
[Perf] Fail fast on unhandled exceptions in Reactor threads
mikeharder May 20, 2021
67e997b
Add comment
mikeharder May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions common/perf-test-core/src/main/java/com/azure/perf/test/core/PerfStressProgram.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,15 @@ public static void runTests(PerfStressTest<?>[] tests, boolean sync, int paralle
throw new RuntimeException(e);
}
} else {
// Exceptions like OutOfMemoryError are handled differently by the default Reactor schedulers. Instead of terminating the
// Flux, the Flux will hang and the exception is only sent to the thread's uncaughtExceptionHandler and the Reactor
// Schedulers.onHandleError. This handler ensures the perf framework will fail fast on any such exceptions.
Schedulers.onHandleError((t, e) -> {
System.err.print(t + " threw exception: ");
e.printStackTrace();
System.exit(1);
});

Flux.range(0, parallel)
.parallel()
.runOn(Schedulers.boundedElastic())
Expand Down