App config remove revisions#21696
Merged
Merged
Conversation
mrm9084
requested review from
backwind1233,
chenrujun,
saragluna,
stliu and
yiliuTo
as code owners
May 20, 2021 22:09
ghost
added
the
…or-java into AppConfigRemoveRevisions
…ConfigRemoveRevisions
6 tasks
Member
Author
@saragluna There are multiple known issues that are caused by this. 1) Revision history only lasts 30 days, 2) Revisions can't tell if a key has been deleted. 3) We only need the latest etag, with the new requirement of a watch key we can just request the key. This change also brings the Spring implementation closer to the other ones we have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes use of revisions endpoint