file list v2 behavior fixes - #22509
Merged
Merged
Conversation
jaschrep-msft
requested review from
alzimmermsft,
amishra-dev,
gapra-msft,
kasobol-msft and
rickle-msft
as code owners
June 24, 2021 21:27
ghost
added
the
jaschrep-msft
commented
Jun 24, 2021
Comment on lines
+385
to
+416
| given: | ||
| primaryDirectoryClient.create() | ||
| def nameList = new LinkedList() | ||
| def dirPrefix = namer.getRandomName(60) | ||
| for (int i = 0; i < 2; i++) { | ||
| def subDirClient = primaryDirectoryClient.getSubdirectoryClient(dirPrefix + i) | ||
| subDirClient.create() | ||
| for (int j = 0; j < 2; j++) { | ||
| def num = i * 2 + j + 3 | ||
| subDirClient.createFile(dirPrefix + num, 1024) | ||
| } | ||
| } | ||
| primaryDirectoryClient.createFile(dirPrefix + 2, 1024) | ||
| for (int i = 0; i < 3; i++) { | ||
| nameList.add(dirPrefix + i) | ||
| } | ||
|
|
||
| when: | ||
| def fileRefIter = primaryDirectoryClient.listFilesAndDirectories(namer.getResourcePrefix() + extraPrefix, maxResults, null, null).iterator() | ||
|
|
||
| then: | ||
| for (int i = 0; i < numOfResults; i++) { | ||
| Objects.equals(nameList.pop(), fileRefIter.next().getName()) | ||
| } | ||
| !fileRefIter.hasNext() | ||
|
|
||
| where: | ||
| extraPrefix | maxResults | numOfResults | ||
| "" | null | 3 | ||
| "" | 1 | 3 | ||
| "noOp" | 3 | 0 | ||
| } |
Member
Author
There was a problem hiding this comment.
This is a reversion to the old test, keeping old and new service version functionality tested separately.
gapra-msft
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responding to post-merge comments on #21720