EventHubs: Fix Span links on send - #28951
Merged
Merged
Conversation
added 2 commits
May 18, 2022 17:52
lmolkova
requested review from
anuchandy,
anushkasingh16,
conniey,
geagin,
haolingdong-msft,
ki1729,
liukun-msft,
srnagar and
weidongxu-microsoft
as code owners
May 19, 2022 02:29
ghost
added
the
Collaborator
|
API change check API changes are not detected in this pull request. |
Author
|
/cc @trask |
trask
approved these changes
May 20, 2022
conniey
approved these changes
May 23, 2022
conniey
left a comment
conniey
left a comment
Member
There was a problem hiding this comment.
Can you update the CHANGELOG.md with your changes?
Thanks so much!
anuchandy
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing context population on send span.
OTelTracer expects to see
SpanContextinstance underspan-contextkey and instead it gets two nestedspan-context keys:com.azure.utils.Context[span-context]:com.azure.utils.Context[span-context]:SpanContext