Skip to content

Enable Checkstyle fail on error / violation for Key Vault #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonathanGiles merged 5 commits into from
Mar 6, 2019
Merged

Enable Checkstyle fail on error / violation for Key Vault #2969

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2091c02
Now that KeyVault data-plane has no more checkstyle errors or violati…
JonathanGiles Feb 25, 2019
38f39d0
Install build tools locally so that checkstyle can run.
JonathanGiles Feb 25, 2019
e08f3ef
Fix whitespace
JonathanGiles Feb 25, 2019
56e7b96
It is not necessary to run checkstyle:check as the build will fail sa…
JonathanGiles Mar 6, 2019
975796d
Merge branch 'master' into checkstyle-keyvault-fail-conditions
JonathanGiles Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions keyvault/data-plane/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
</dependencyManagement>

<build>

<plugins>

<!-- This plugin is used to compile the sources of your project. -->
Expand All @@ -89,12 +88,20 @@
<compilerArgument>-Xlint:unchecked</compilerArgument>
</configuration>
</plugin>


<!-- Now that all checkstyle issues have been resolved, override the
default behavior to make checkstyle fail on error and violation. -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<failsOnError>true</failsOnError>
<failOnViolation>true</failOnViolation>
</configuration>
</plugin>
</plugins>

</build>


<developers>
<developer>
<id>microsoft</id>
Expand Down