Skip to content

Updated Key Vault documentation to direct users use managed identity authentication by default. - #29995

Merged
vcolin7 merged 10 commits into
Azure:mainfrom
vcolin7:key-vault-doc-updates
Aug 3, 2022
Merged

Updated Key Vault documentation to direct users use managed identity authentication by default.#29995
vcolin7 merged 10 commits into
Azure:mainfrom
vcolin7:key-vault-doc-updates

Conversation

@vcolin7

@vcolin7 vcolin7 commented Jul 18, 2022

Copy link
Copy Markdown
Member

Based on #29725.

Updated READMEs and samples for all 4 Key Vault data plane libraries to direct users to authenticate using a managed identity instead of client credentials. Did some cleaning up as well.

@vcolin7 vcolin7 added KeyVault Client This issue points to a problem in the data-plane of the library. Docs Samples labels Jul 18, 2022
@vcolin7 vcolin7 added this to the 2022-08 milestone Jul 18, 2022
@vcolin7 vcolin7 self-assigned this Jul 18, 2022
@vcolin7
vcolin7 requested review from g2vinay and samvaity as code owners July 18, 2022 06:12
@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@vcolin7
vcolin7 requested a review from gearama July 18, 2022 06:34
Comment thread sdk/keyvault/azure-security-keyvault-administration/README.md Outdated
Comment thread sdk/keyvault/azure-security-keyvault-secrets/README.md Outdated
Comment thread sdk/keyvault/azure-security-keyvault-certificates/README.md Outdated
Comment thread sdk/keyvault/azure-security-keyvault-administration/README.md Outdated
@check-enforcer

check-enforcer Bot commented Aug 3, 2022

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@vcolin7
vcolin7 merged commit 39f2aaf into Azure:main Aug 3, 2022
@pallavit pallavit removed this from the 2022-08 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Docs KeyVault Samples

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants