Skip to content

Merge changes from master into azconfig#3055

Merged
conniey merged 14 commits into
Azure:azconfigfrom
conniey:azconfig
Mar 7, 2019
Merged

Merge changes from master into azconfig#3055
conniey merged 14 commits into
Azure:azconfigfrom
conniey:azconfig

Conversation

@conniey

@conniey conniey commented Mar 7, 2019

Copy link
Copy Markdown
Member

No description provided.

weshaggard and others added 14 commits February 26, 2019 15:00
* Adding suppression for having named static inner classes from anonymous.

* Add suppression for redundant null check.

* Move SIC_INNER_SHOULD_BE_STATIC suppression

* Make anonymous class in CachingKeyResolver a named inner static.

* Include missing impl classes for auto-rest when it generates a variable with known null value

* Suppressing unconfirmed casts because we know the cast is correct but the APIs weren't designed for it
…on 1.0.0 (Azure#2975)

* Bumping up resource-manager parent pom to 1.0.0

* Bumping up eventgrid.v2019_01_01 to version 1.0.0
…java codegen (Azure#3009)

* Generated from e92e525831933bedf2242fe607984757387be1b2

Add private dns module name for java codegen

* Update pom for private dns

* change private dns version back to beta
* Suppress using Nullable parameter as non-null for KeyVaultKey because it was a scenario in original SDK not thought of.

* Suppress return empty array rather than null

* Add null check for service to ensure it has been initialized

* Checking for null service value before invoking method

* Catching specific exceptions rather than Exception e

* Use 8L so that the integer multiplication is not implicitly cast to long.

* Add exclude for catch Exception in CachingKeyResolver

* Catching specific exceptions rather than Exception e
- Update whitespace to match Prettier formatting
- Add .prettierrc.yml
- Part of Azure/azure-sdk#225
license/cla override. Check isn't coming back for some reason.
* Adding .editorconfig

* Add .gitattributes

* Reformat pom.client.xml

* Reformat keyvault/data-plane/pom.xml

* Reformat batch/data-plane/pom.xml
* Now that KeyVault data-plane has no more checkstyle errors or violations, we are now enforcing build failure for this project and all child modules.

* Install build tools locally so that checkstyle can run.

* Fix whitespace

* It is not necessary to run checkstyle:check as the build will fail satisfactorily under the analyze job.
Record/Playback Integration in Azure Batch Java SDK tests. 
Added Test recordings to be used in playback mode.
@conniey conniey added the Client This issue points to a problem in the data-plane of the library. label Mar 7, 2019
@conniey conniey self-assigned this Mar 7, 2019
@azuresdkci

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@conniey
conniey merged commit 1525dc7 into Azure:azconfig Mar 7, 2019
@conniey
conniey deleted the azconfig branch March 7, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants