Skip to content

Fix 252: Table: Need to support signing when URL contains escapable characters#31

Merged
jcookems merged 5 commits into
Azure:dev-bookmarkfrom
jcookems:fix252
Apr 4, 2012
Merged

Fix 252: Table: Need to support signing when URL contains escapable characters#31
jcookems merged 5 commits into
Azure:dev-bookmarkfrom
jcookems:fix252

Conversation

@jcookems

Copy link
Copy Markdown
Contributor

No description provided.

jcookems added 3 commits March 8, 2012 10:22
Changed catch statement to perform a reasonable fallback if the URLEncoder call fails.
Added missing imports statements.
@jcookems

jcookems commented Apr 3, 2012

Copy link
Copy Markdown
Contributor Author

Added a unit test and addressed the review feedback.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to assert the success of the deletion by validating the original entities do not exist any more?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I'll add that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below for the new asserts

jcookems added a commit that referenced this pull request Apr 4, 2012
Fix 252: Table: Need to support signing when URL contains escapable characters
@jcookems jcookems merged commit 7ea8763 into Azure:dev-bookmark Apr 4, 2012
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this pull request Jan 18, 2013
implement the get version of MediaProcessorType
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this pull request Jan 18, 2013
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this pull request Jan 18, 2013
Remove wrapper code that corresponds to non-existant processors
gcheng pushed a commit that referenced this pull request Apr 12, 2013
andrerod pushed a commit that referenced this pull request May 9, 2014
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Apr 5, 2017
Fix 252: Table: Need to support signing when URL contains escapable characters
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Apr 5, 2017
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this pull request Mar 4, 2019
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this pull request May 30, 2019
samvaity added a commit to samvaity/azure-sdk-for-java that referenced this pull request Dec 18, 2019
navalev pushed a commit to navalev/azure-sdk-for-java that referenced this pull request Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants