Add CI Test Run using Latest JDK

eng/pipelines/templates/jobs/ci.tests.yml

@@ -75,6 +75,8 @@ jobs:
           CheckoutRecordings: true
           SDKType: ${{ parameters.SDKType }}
 
+      - template: ../steps/install-latest-jdk.yml
+
       - template: ../steps/install-reporting-tools.yml
         parameters:
           JdkVersion: $(JavaTestVersion)

eng/pipelines/templates/jobs/live.tests.yml

@@ -54,6 +54,8 @@ jobs:
           ServiceDirectory: ${{ parameters.ServiceDirectory }}
           SDKType: ${{ parameters.SDKType }}
 
+      - template: ../steps/install-latest-jdk.yml
+
       - template: ../steps/install-reporting-tools.yml
         parameters:
           JdkVersion: $(JavaTestVersion)

eng/pipelines/templates/stages/archetype-sdk-client.yml

@@ -97,7 +97,7 @@ stages:
 
           - AZURE_TEST.*=.*/
           - ${{ if eq(parameters.SDKType, 'data') }}:
-            - JavaTestVersion=(.*1)\.17(.*)/$1.11$2
+            - JavaTestVersion=(.*1)\.\d{2}(.*)/$1.11$2
         PreBuildSteps: ${{ parameters.PreBuildSteps }}
         AdditionalLintingOptions: ${{ parameters.AdditionalLintingOptions }}
         ${{ if eq(parameters.SDKType, 'data') }}:

eng/pipelines/templates/stages/platform-matrix.json

@@ -50,6 +50,16 @@
       "TestFromSource": false,
       "TestGoals": "surefire:test",
       "TestOptions": ""
+    },
+    {
+      "Agent": {
+        "ubuntu-20.04": { "OSVmImage": "MMSUbuntu20.04", "Pool": "azsdk-pool-mms-ubuntu-2004-general" }
+      },
+      "JavaTestVersion": "1.19",
+      "AZURE_TEST_HTTP_CLIENTS": "netty",
+      "TestFromSource": false,
+      "TestGoals": "surefire:test",
+      "TestOptions": ""
     }
   ]
 }

eng/pipelines/templates/steps/build-and-test.yml

@@ -54,6 +54,7 @@ steps:
     env:
       AZURE_VERSION_OVERRIDE_TESTS: ${{ parameters.TestVersionSupport }}
     condition: and(succeeded(), ne(variables['TestFromSource'], 'true'))
+    continueOnError: ${{ eq(variables['LatestJdkVersion'], variables['JavaTestVersion']) }}
 
   - task: Maven@3
     displayName: 'Run tests'
@@ -69,6 +70,7 @@ steps:
     env: ${{ parameters.TestEnvVars }}
     # we want to run this when TestFromSource isn't true
     condition: and(succeeded(), ne(variables['TestFromSource'], 'true'))
+    continueOnError: ${{ eq(variables['LatestJdkVersion'], variables['JavaTestVersion']) }}
 
   # Generate the pom file with all the modules required for creating an aggregate code coverage report
   - task: PythonScript@0

eng/pipelines/templates/steps/initialize-test-environment.yml

@@ -16,7 +16,7 @@ parameters:
 
 steps:
   # Skip sparse checkout for the `azure-sdk-for-<lang>-pr` private mirrored repositories
-  # as we require the github service connection to be loaded.
+  # as we require the GitHub service connection to be loaded.
   - ${{ if not(contains(variables['Build.DefinitionName'], 'java-pr')) }}:
     - template: /eng/common/pipelines/templates/steps/sparse-checkout.yml
       parameters:
@@ -86,7 +86,7 @@ steps:
     condition: and(succeeded(), eq(variables['TestFromSource'], 'true'))
 
   # Skip sparse checkout for the `azure-sdk-for-<lang>-pr` private mirrored repositories
-  # as we require the github service connection to be loaded.
+  # as we require the GitHub service connection to be loaded.
   - ${{ if not(contains(variables['Build.DefinitionName'], 'java-pr')) }}:
     - template: /eng/common/pipelines/templates/steps/sparse-checkout.yml
       parameters:

eng/pipelines/templates/steps/install-latest-jdk.yml

@@ -0,0 +1,27 @@
+steps:
+  # Non-standard JDK versions are only supported in Linux.
+  # Make the assumption here Linux is being used, if it's not it's a configuration issue that needs to be fixed there.
+  - task: Cache@2
+    inputs:
+      key: 'jdk | "$(JavaTestVersion)" | "$(CacheSalt)" | "$(Agent.OS)"'
+      path: $(Agent.BuildDirectory)/jdk-$(LatestJdkFeatureVersion)
+    displayName: 'Cache Latest JDK'
+    condition: eq(variables['LatestJdkVersion'], variables['JavaTestVersion'])
+
+  - task: PowerShell@2
+    displayName: 'Install Latest JDK'
+    inputs:
+      pwsh: true
+      arguments: >
+        -JdkFeatureVersion $(LatestJdkFeatureVersion)
+      workingDirectory: $(Agent.BuildDirectory)
+      filePath: eng/scripts/Install-Latest-JDK.ps1
+    condition: eq(variables['LatestJdkVersion'], variables['JavaTestVersion'])
+
+  - pwsh: |
+      Write-Host "Java 8 JDK: $Env:JAVA_HOME_8_X64"
+      Write-Host "Java 11 JDK: $Env:JAVA_HOME_11_X64"
+      Write-Host "Java 17 JDK: $Env:JAVA_HOME_17_X64"
+      Write-Host "Latest JDK: $Env:JAVA_HOME_$(LatestJdkFeatureVersion)_X64"
+    displayName: 'Verify Latest JDK Install'
+    condition: eq(variables['LatestJdkVersion'], variables['JavaTestVersion'])

eng/pipelines/templates/variables/globals.yml

@@ -4,6 +4,9 @@ variables:
   JavaBuildVersion: '1.17'
   # This is the default Java test version. It's the version used when running tests.
   JavaTestVersion: '1.17'
+  # This is the latest JDK version.
+  LatestJdkVersion: '1.19'
+  LatestJdkFeatureVersion: '19'
   # This is the version of Python used by various tools in the Java build/release processes
   PythonVersion: '3.9'
 

eng/scripts/Install-Latest-JDK.ps1

@@ -0,0 +1,53 @@
+[CmdletBinding()]
+param(
+    [Parameter(Mandatory=$true)]
+    [string]$JdkFeatureVersion
+)
+
+# Query Adoptium for the list of installs for the JDK feature version.
+$adoptiumApiUrl = "https://api.adoptium.net"
+$os
+
+if ($IsWindows) {
+  $os = "windows"
+} elseif ($IsMacOS) {
+  $os = "mac"
+} else {
+  $os = "linux"
+}
+
+$getInstalls = "$adoptiumApiUrl/v3/assets/latest/$JdkFeatureVersion/hotspot?architecture=x64&image_type=jdk&os=$os&vendor=eclipse"
+$jdkUnzipName = "jdk-$JdkFeatureVersion"
+
+Write-Host "Downloading latest JDK to" (Get-Location)
+
+if (!(Test-Path -Path $jdkUnzipName -PathType container)) {
+  # Query Adoptium for the list of installs for the JDK feature version.
+  Write-Host "Inkvoking web request to '$getInstalls' to find JDK $JdkFeatureVersion installs available on $os."
+  $installsAvailable = Invoke-WebRequest -URI $getInstalls | ConvertFrom-Json
+  $jdkLink = $installsAvailable.binary.package.link
+  $jdkZipName = $jdkLink.split("/")[-1]
+
+  Write-Host "Downloading install from '$jdkLink' to '$jdkZipName'."
+  Invoke-WebRequest -URI $jdkLink -OutFile $jdkZipName
+
+  if ($IsWindows) {
+    Expand-Archive -Path $jdkZipName -Destination "jdk-temp"
+    Move-Item -Path (Join-Path -Path "jdk-temp" -ChildPath (Get-ChildItem "jdk-temp")[0].Name) -Destination $jdkUnzipName
+  } else {
+    New-Item -Path "jdk-temp" -ItemType "directory"
+    tar -xvf $jdkZipName -C "jdk-temp"
+    Move-Item -Path (Join-Path -Path "jdk-temp" -ChildPath (Get-ChildItem "jdk-temp")[0].Name) -Destination $jdkUnzipName
+  }
+
+}
+
+$javaHome = (Convert-Path $jdkUnzipName)
+Write-Host "Latest JDK: $javaHome"
+
+Write-Host "Current JAVA_HOME: $Env:JAVA_HOME"
+Write-Host "##vso[task.setvariable variable=JAVA_HOME;]$javaHome"
+Write-Host "Updated JAVA_HOME: $Env:JAVA_HOME"
+
+$jdkFeatureVersionJavaHome = "JAVA_HOME_" + $JdkFeatureVersion + "_X64"
+Write-Host "##vso[task.setvariable variable=$jdkFeatureVersionJavaHome;]$javaHome"

sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/models/CbsAuthorizationType.java

@@ -10,6 +10,18 @@
  * An enumeration of supported authorization methods with the {@link ClaimsBasedSecurityNode}.
  */
 public final class CbsAuthorizationType extends ExpandableStringEnum<CbsAuthorizationType> {
+    /**
+     * Creates a new instance of {@link CbsAuthorizationType} without a {@link #toString()} value.
+     * <p>
+     * This constructor shouldn't be called as it will produce a {@link CbsAuthorizationType} which doesn't have a
+     * String enum value.
+     *
+     * @deprecated Use one of the constants or the {@link #fromString(String, Class)} factory method.
+     */
+    @Deprecated
+    public CbsAuthorizationType() {
+    }
+
     /**
      * Authorize with CBS through a shared access signature.
      */
@@ -18,7 +30,7 @@ public final class CbsAuthorizationType extends ExpandableStringEnum<CbsAuthoriz
 
     /**
      * Authorize with CBS using a JSON web token.
-     *
+     * <p>
      * This is used in the case where Azure Active Directory is used for authentication and the authenticated user
      * wants to authorize with Azure Event Hubs.
      */

sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/models/DeliveryState.java

@@ -41,6 +41,18 @@ public final class DeliveryState extends ExpandableStringEnum<DeliveryState> {
      */
     public static final DeliveryState TRANSACTIONAL = fromString("TRANSACTIONAL", DeliveryState.class);
 
+    /**
+     * Creates a new instance of {@link DeliveryState} without a {@link #toString()} value.
+     * <p>
+     * This constructor shouldn't be called as it will produce a {@link DeliveryState} which doesn't have a String
+     * enum value.
+     *
+     * @deprecated Use one of the constants or the {@link #fromString(String, Class)} factory method.
+     */
+    @Deprecated
+    public DeliveryState() {
+    }
+
     /**
      * Gets the corresponding delivery state from its string representation.
      *

sdk/core/azure-core-management/src/main/java/com/azure/core/management/ResourceAuthorIdentityType.java

@@ -22,6 +22,18 @@ public final class ResourceAuthorIdentityType extends ExpandableStringEnum<Resou
     /** Static value Key for ResourceAuthorIdentityType. */
     public static final ResourceAuthorIdentityType KEY = fromString("Key");
 
+    /**
+     * Creates a new instance of {@link ResourceAuthorIdentityType} without a {@link #toString()} value.
+     * <p>
+     * This constructor shouldn't be called as it will produce a {@link ResourceAuthorIdentityType} which doesn't have a
+     * String enum value.
+     *
+     * @deprecated Use one of the constants or the {@link #fromString(String, Class)} factory method.
+     */
+    @Deprecated
+    public ResourceAuthorIdentityType() {
+    }
+
     /**
      * Creates or finds a ResourceAuthorIdentityType from its string representation.
      *

sdk/core/azure-core/src/main/java/com/azure/core/annotation/BodyParam.java

@@ -43,7 +43,9 @@
 @Target(PARAMETER)
 public @interface BodyParam {
     /**
-     * @return the Content-Type that the body should be treated as
+     * Gets the Content-Type for the body.
+     *
+     * @return The Content-Type for the body.
      */
     String value();
 }

sdk/core/azure-core/src/main/java/com/azure/core/annotation/FormParam.java

@@ -29,14 +29,15 @@
 @Target(PARAMETER)
 public @interface FormParam {
     /**
+     * Gets the name of the key in a key-value pair as part of the form data.
+     *
      * @return The name of the key in a key value pair as part of the form data.
      */
     String value();
 
     /**
      * Whether the form parameter is already form encoded.
      * <p>
-     *
      * A value true for this argument indicates that value of {@link FormParam#value()} is already encoded hence engine
      * should not encode it, by default value will be encoded.
      *

sdk/core/azure-core/src/main/java/com/azure/core/annotation/UnexpectedResponseExceptionTypes.java

@@ -18,6 +18,8 @@
 @Target(METHOD)
 public @interface UnexpectedResponseExceptionTypes {
     /**
+     * Gets an array of {@link UnexpectedResponseExceptionType} that annotate a method.
+     *
      * @return array of {@link UnexpectedResponseExceptionType} that annotate a method.
      */
     UnexpectedResponseExceptionType[] value();

sdk/core/azure-core/src/main/java/com/azure/core/credential/AccessToken.java

@@ -14,6 +14,7 @@ public class AccessToken {
 
     /**
      * Creates an access token instance.
+     *
      * @param token the token string.
      * @param expiresAt the expiration time.
      */
@@ -23,21 +24,27 @@ public AccessToken(String token, OffsetDateTime expiresAt) {
     }
 
     /**
-     * @return the token string.
+     * Gets the token.
+     *
+     * @return The token.
      */
     public String getToken() {
         return token;
     }
 
     /**
-     * @return the time when the token expires, in UTC.
+     * Gets the time when the token expires, in UTC.
+     *
+     * @return The time when the token expires, in UTC.
      */
     public OffsetDateTime getExpiresAt() {
         return expiresAt;
     }
 
     /**
-     * @return if the token has expired.
+     * Whether the token has expired.
+     *
+     * @return Whether the token has expired.
      */
     public boolean isExpired() {
         return OffsetDateTime.now().isAfter(expiresAt);

sdk/core/azure-core/src/main/java/com/azure/core/exception/HttpRequestException.java

@@ -77,6 +77,8 @@ public HttpRequestException(final String message, final HttpRequest request, fin
     }
 
     /**
+     * Gets the {@link HttpRequest} being sent when the exception occurred.
+     *
      * @return The {@link HttpRequest} being sent when the exception occurred.
      */
     public HttpRequest getRequest() {

sdk/core/azure-core/src/main/java/com/azure/core/exception/HttpResponseException.java

@@ -99,13 +99,17 @@ public HttpResponseException(final String message, final HttpResponse response,
     }
 
     /**
+     * Gets the {@link HttpResponse} received that is associated to the exception.
+     *
      * @return The {@link HttpResponse} received that is associated to the exception.
      */
     public HttpResponse getResponse() {
         return response;
     }
 
     /**
+     * Gets the deserialized HTTP response value.
+     *
      * @return The deserialized HTTP response value.
      */
     public Object getValue() {

sdk/core/azure-core/src/main/java/com/azure/core/http/HttpAuthorization.java

@@ -42,13 +42,17 @@ public HttpAuthorization(String scheme, String parameter) {
     }
 
     /**
+     * Gets the scheme of the authorization header.
+     *
      * @return Scheme of the authorization header.
      */
     public String getScheme() {
         return scheme;
     }
 
     /**
+     * Gets the credential of the authorization header.
+     *
      * @return Credential of the authorization header.
      */
     public String getParameter() {

sdk/core/azure-core/src/main/java/com/azure/core/http/MatchConditions.java

@@ -13,6 +13,12 @@ public class MatchConditions {
     private String ifMatch;
     private String ifNoneMatch;
 
+    /**
+     * Creates a new instance of {@link MatchConditions}.
+     */
+    public MatchConditions() {
+    }
+
     /**
      * Gets the ETag that resources must match.
      *