[Automation] Generate Fluent Lite from dynatrace#package-2021-09-01 - #31007
Closed
azure-sdk wants to merge 1 commit into
Closed
[Automation] Generate Fluent Lite from dynatrace#package-2021-09-01#31007azure-sdk wants to merge 1 commit into
azure-sdk wants to merge 1 commit into
Conversation
azure-sdk
requested review from
ArthurMa1978,
XiaofeiCao,
haolingdong-msft and
weidongxu-microsoft
as code owners
September 19, 2022 01:41
XiaofeiCao
reviewed
Sep 19, 2022
| public void testDeserialize() { | ||
| AccountInfoSecureInner model = | ||
| BinaryData | ||
| .fromString("{\"accountId\":\"mhquvgjxp\",\"apiKey\":\"czmehmtzopbsp\",\"regionId\":\"upi\"}") |
Contributor
There was a problem hiding this comment.
CI reported credential check error for apikey:
A potential secret was detected in 'AccountInfoSecureInnerTests.java':(CSCAN-GENERAL0130 Client Secret / Api Key) Validate file contains secrets, remove, roll credential, and use approved store
Should we replace them with appropriate values in codegen?
Member
There was a problem hiding this comment.
For now, just disable generate-tests?
We might later add logic to skip e.g. apiKey property (or the model) when generating the mock JSON in codegen. However we don't know exactly what will be flagged and what will not...
Member
There was a problem hiding this comment.
Or you can just delete the tests folder in the PR.
Contributor
|
Close due to generate-test failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Automation] Generate Fluent Lite from dynatrace#package-2021-09-01