Skip to content

Update Spring Cloud Azure Support File in branch feature/spring-boot-3#31181

Merged
moarychan merged 7 commits into
Azure:feature/spring-boot-3from
moarychan:moary/update-spring-cloud-azure-support-file
Sep 29, 2022
Merged

Update Spring Cloud Azure Support File in branch feature/spring-boot-3#31181
moarychan merged 7 commits into
Azure:feature/spring-boot-3from
moarychan:moary/update-spring-cloud-azure-support-file

Conversation

@moarychan

Copy link
Copy Markdown
Member

Update Spring Boot and Spring Cloud versions for the compatibility test.

If you merged this PR, please update Spring Cloud Azure Timeline.

@ghost ghost added the azure-spring All azure-spring related issues label Sep 28, 2022
@azure-sdk

azure-sdk commented Sep 28, 2022

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure

@moarychan
moarychan marked this pull request as ready for review September 29, 2022 04:35
@moarychan

Copy link
Copy Markdown
Member Author

@saragluna , the compatibility test for SB M5 passed, https://dev.azure.com/azure-sdk/public/_build/results?buildId=1883844&view=results please help review, thanks!

@moarychan moarychan self-assigned this Sep 29, 2022
@moarychan moarychan added this to the 2022-10 milestone Sep 29, 2022
)),

REDIS("spring.redis", "azure-rediscache",
REDIS("spring.data.redis", "azure-rediscache",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't change this, will the UT fail?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +109 to +116
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.10.1</version> <!-- {x-version-update;org.apache.maven.plugins:maven-compiler-plugin;external_dependency} -->
<configuration>
<failOnWarning>false</failOnWarning>
</configuration>
</plugin>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to suppress what kind of warnings?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you point me to the source code where ListenableFutureCallback is used?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change to CompletableFuture then, instead of using the deprecated one.

@moarychan
moarychan merged commit 841710f into Azure:feature/spring-boot-3 Sep 29, 2022
moarychan added a commit to moarychan/azure-sdk-for-java that referenced this pull request Sep 30, 2022
moarychan added a commit that referenced this pull request Sep 30, 2022
@moarychan
moarychan deleted the moary/update-spring-cloud-azure-support-file branch October 26, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants