Fixes 31191 Duplicated Scopes - #31290
Closed
0x006EA1E5 wants to merge 1 commit into
Closed
Conversation
* Call addParametersConverter(...) and addHeadersConverter(...) in constructor of AbstractOAuth2AuthorizationCodeGrantRequestEntityConverter instead of convert(...) method * Ensure AadRestTemplateCreator.createOAuth2AccessTokenResponseClientRestTemplate(...) only contains FormHttpMessageConverter and OAuth2AccessTokenResponseHttpMessageConverter
0x006EA1E5
requested review from
Netyyyy,
backwind1233,
chenrujun,
fangjian0423,
hui1110,
moarychan,
saragluna,
stliu and
yiliuTo
as code owners
October 6, 2022 14:54
|
|
ghost
added
azure-spring
|
Thank you for your contribution 0x006EA1E5! We will review the pull request and get back to you soon. |
chenrujun
added
bug
chenrujun
reviewed
Oct 8, 2022
| private static final TypeReference<Map<String, OAuth2AuthorizedClient>> TYPE_REFERENCE = | ||
| new TypeReference<Map<String, OAuth2AuthorizedClient>>() { | ||
| }; | ||
| new TypeReference<>() {}; |
There was a problem hiding this comment.
This will cause pipeline failure: https://github.com/Azure/azure-sdk-for-java/pull/31290/checks?check_run_id=8746380895
| authorizedClientsMap.put(authorizedClient.getClientRegistration().getRegistrationId(), authorizedClient); | ||
| request.getSession().setAttribute(AUTHORIZED_CLIENTS_ATTR_NAME, | ||
| serializeOAuth2AuthorizedClientMap(authorizedClients)); | ||
| serializeOAuth2AuthorizedClientMap(Collections.unmodifiableMap(authorizedClientsMap))); |
There was a problem hiding this comment.
Good point. This will make the code more robust.
|
Closing this PR in favor of #31213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
addParametersConverter(...)andaddHeadersConverter(...)in constructor of AbstractOAuth2AuthorizationCodeGrantRequestEntityConverter instead ofconvert(...)methodAadRestTemplateCreator.createOAuth2AccessTokenResponseClientRestTemplate(...)only containsFormHttpMessageConverterandOAuth2AccessTokenResponseHttpMessageConverterAll SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines