Skip to content

Fix 31218 rest template is not well configured when jwk resolver is null - #31480

Merged
chenrujun merged 7 commits into
Azure:mainfrom
chenrujun:fix-31218-rest-template-is-not-well-configured-when-jwkResolver-is-null
Oct 17, 2022
Merged

Fix 31218 rest template is not well configured when jwk resolver is null#31480
chenrujun merged 7 commits into
Azure:mainfrom
chenrujun:fix-31218-rest-template-is-not-well-configured-when-jwkResolver-is-null

Conversation

@chenrujun

Copy link
Copy Markdown

Description

  1. Fix [BUG] RestOperations is not well configured when jwkResolver is null #31218 , add unit-tests.
  2. Remove duplicated method of getField.

@ghost ghost added the azure-spring All azure-spring related issues label Oct 14, 2022
@chenrujun chenrujun self-assigned this Oct 14, 2022
@chenrujun chenrujun added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. azure-spring-aad Spring active directory related issues. labels Oct 14, 2022
@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@chenrujun
chenrujun force-pushed the fix-31218-rest-template-is-not-well-configured-when-jwkResolver-is-null branch from 7e540ec to 6c21530 Compare October 14, 2022 07:09
@chenrujun

Copy link
Copy Markdown
Author

Hi, @saragluna , @moarychan , please help to review this PR when you have time.

@moarychan moarychan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please help to merge these changes into feature/-spring-boot-3 branch.

@chenrujun
chenrujun merged commit a2c534b into Azure:main Oct 17, 2022
@chenrujun
chenrujun deleted the fix-31218-rest-template-is-not-well-configured-when-jwkResolver-is-null branch October 17, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] RestOperations is not well configured when jwkResolver is null

4 participants