Issue 31482 rest template used to get access token should only contains 2 converters#31489
Merged
Conversation
…mplate: Use builder instead of setErrorHandler.
2. Delete unnecessary method.
…ntain 2 converters.
chenrujun
requested review from
Netyyyy,
backwind1233,
fangjian0423,
hui1110,
moarychan,
saragluna,
stliu and
yiliuTo
as code owners
October 14, 2022 08:35
ghost
added
the
chenrujun
added
bug
Collaborator
|
API change check API changes are not detected in this pull request. |
Author
|
Hi, @saragluna , @moarychan , please help to review this PR when you have time. |
…token-should-only-contains-2-converters
…token-should-only-contains-2-converters
moarychan
reviewed
Oct 17, 2022
|
|
||
| private static boolean notContainsElementOfType(List<?> list, Class<?> clazz) { | ||
| return list.stream().noneMatch(item -> item.getClass().equals(clazz)); | ||
| builder = builder.messageConverters( |
Member
There was a problem hiding this comment.
Shall we set the message converters and error handler based on the rest template instance, not the rest template builder?
Author
There was a problem hiding this comment.
It's the same. The build.xxx will create a new builder instance instead of modifying current instance. See this: #31213 (comment)
chenrujun
deleted the
issue-31482-RestTemplate-used-to-get-access-token-should-only-contains-2-converters
branch
October 17, 2022 06:51
|
Hi, |
Author
|
The target version is 4.4.1, and planned to be released before 2022-11-1 |
Thanks very much for the response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.