healthCheckImprovement[transitTimeout] - #31544
Merged
Merged
Conversation
ghost
added
the
Collaborator
|
API change check API changes are not detected in this pull request. |
xinlian12
marked this pull request as ready for review
October 18, 2022 05:11
xinlian12
requested review from
FabianMeiswinkel,
aayush3011,
kirankumarkolli,
kushagraThapar,
milismsft and
simorenoh
as code owners
October 18, 2022 05:11
kushagraThapar
approved these changes
Oct 25, 2022
kushagraThapar
left a comment
kushagraThapar
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks @xinlian12 , great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
One of the main mechanism within SDK to detect a broken connection is during the health check flow. The current implementation will not be able to detect a broken connection under relative high workload.
Soltuion
when a connection is in a broken status - usually it will cause the network request fail with transit timeout (client side generated timeout). In this PR, we are adding a tracking for continuous transitTimeout counter, and integrate it into the healthy check flow to help detect the broken connection faster.