Skip to content

Enable sync stack for Container registry#31584

Merged
samvaity merged 10 commits into
Azure:mainfrom
samvaity:sync-stack-container
Dec 14, 2022
Merged

Enable sync stack for Container registry#31584
samvaity merged 10 commits into
Azure:mainfrom
samvaity:sync-stack-container

Conversation

@samvaity

Copy link
Copy Markdown
Member

No description provided.

@samvaity samvaity force-pushed the sync-stack-container branch from b73e04a to 86d1711 Compare November 8, 2022 21:50
@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-containers-containerregistry

@samvaity samvaity force-pushed the sync-stack-container branch from 5b65a62 to f17d9aa Compare November 11, 2022 00:29
@samvaity samvaity force-pushed the sync-stack-container branch from 1de9650 to 7e0ed6c Compare November 18, 2022 20:42
@samvaity samvaity force-pushed the sync-stack-container branch 2 times, most recently from 245307c to 7ae6e05 Compare November 21, 2022 18:56
@samvaity

Copy link
Copy Markdown
Member Author

/azp run java - containerregistry - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@samvaity samvaity force-pushed the sync-stack-container branch from 7ae6e05 to 0295237 Compare November 22, 2022 00:20
@samvaity

Copy link
Copy Markdown
Member Author

/azp run java - containerregistry - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@samvaity

samvaity commented Dec 6, 2022

Copy link
Copy Markdown
Member Author

/azp run java - containerregistry - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@samvaity samvaity force-pushed the sync-stack-container branch from 0295237 to 9cd50fc Compare December 6, 2022 19:57
@samvaity samvaity force-pushed the sync-stack-container branch from 9cd50fc to a3cb187 Compare December 6, 2022 20:30
@samvaity

samvaity commented Dec 6, 2022

Copy link
Copy Markdown
Member Author

/azp run java - containerregistry - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@samvaity

samvaity commented Dec 7, 2022

Copy link
Copy Markdown
Member Author

/azp run java - containerregistry - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@samvaity samvaity force-pushed the sync-stack-container branch from e343b17 to fb8116d Compare December 7, 2022 18:52
@samvaity

samvaity commented Dec 7, 2022

Copy link
Copy Markdown
Member Author

/azp run java - containerregistry - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@samvaity

samvaity commented Dec 9, 2022

Copy link
Copy Markdown
Member Author

/azp run java - containerregistry - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@samvaity samvaity force-pushed the sync-stack-container branch from fc13700 to ae95c4b Compare December 10, 2022 00:48
@samvaity samvaity force-pushed the sync-stack-container branch from ae95c4b to a5a8d06 Compare December 12, 2022 04:56
@samvaity

Copy link
Copy Markdown
Member Author

/azp run java - containerregistry - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).


<properties>
<!-- Temporarily skipping code coverage until tests are enabled/added -->
<jacoco.skip>true</jacoco.skip>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samvaity samvaity marked this pull request as ready for review December 12, 2022 18:30
@samvaity samvaity self-assigned this Dec 12, 2022
@samvaity samvaity requested a review from g2vinay December 12, 2022 18:31

@lmolkova lmolkova left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

*/
RegistryArtifact(RegistryArtifactAsync asyncClient) {
this.asyncClient = asyncClient;
RegistryArtifact(String repositoryName, String tagOrDigest, HttpPipeline httpPipeline, String endpoint, String version) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider samvaity#4 that allows to reduce duplication

@samvaity

Copy link
Copy Markdown
Member Author

/azp run java - containerregistry - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@samvaity samvaity force-pushed the sync-stack-container branch from 6eb0641 to 161bde4 Compare December 14, 2022 18:14
@samvaity samvaity requested a review from lmolkova December 14, 2022 18:27

@lmolkova lmolkova left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!!

@samvaity samvaity merged commit 94e5e4a into Azure:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants