Skip to content

Fix #31593: Proxy setting not work in Azure AD B2C web application#31597

Merged
chenrujun merged 7 commits into
Azure:mainfrom
chenrujun:fix-issue-31593-Proxy-setting-not-work-in-Azure-AD-B2C-web-application
Oct 21, 2022
Merged

Fix #31593: Proxy setting not work in Azure AD B2C web application#31597
chenrujun merged 7 commits into
Azure:mainfrom
chenrujun:fix-issue-31593-Proxy-setting-not-work-in-Azure-AD-B2C-web-application

Conversation

@chenrujun

@chenrujun chenrujun commented Oct 20, 2022

Copy link
Copy Markdown

Fix #31593: Proxy setting not work in Azure AD B2C web application.

  1. Fix proxy setting for RestOperation which send http request to https://{directory-name}.b2clogin.com/{directory-name}.onmicrosoft.com/oauth2/v2.0/token?p={flow-name}.
  2. Fix proxy setting for RestOperation which send http request to https://{directory-name}.b2clogin.com/{directory-name}.onmicrosoft.com/discovery/v2.0/keys?p={flow-name}.
  3. Add unit tests and refactor tests.

1. Fix proxy setting for RestOperation which send http request to "../discovery/v2.0/keys?..".
2. Fix proxy setting for RestOperation which send http request to "../oauth2/v2.0/token?..".
3. Add unit tests and refactor tests.
@ghost ghost added the azure-spring All azure-spring related issues label Oct 20, 2022
@chenrujun chenrujun self-assigned this Oct 20, 2022
@chenrujun chenrujun added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. labels Oct 20, 2022
@chenrujun chenrujun added this to the 2022-11 milestone Oct 20, 2022

@saragluna saragluna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The circular dependency is not fixed in this PR, right?

@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure

@chenrujun

chenrujun commented Oct 21, 2022

Copy link
Copy Markdown
Author

@saragluna

The circular dependency is not fixed in this PR, right?

Right.

@chenrujun

Copy link
Copy Markdown
Author

Hi, @saragluna , @moarychan , please help to review this PR when you have time.

@moarychan moarychan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chenrujun
chenrujun merged commit 46ebfb5 into Azure:main Oct 21, 2022
@chenrujun
chenrujun deleted the fix-issue-31593-Proxy-setting-not-work-in-Azure-AD-B2C-web-application branch October 21, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] Proxy setting not work in Azure AD B2C web application

5 participants