Skip to content

Fix bugs caused by supporting azure ad proxy - #31665

Merged
chenrujun merged 8 commits into
Azure:hotfix/spring-cloud-azure-4.4.1from
chenrujun:fix-bugs-caused-by-supporting-Azure-AD-proxy
Oct 24, 2022
Merged

Fix bugs caused by supporting azure ad proxy#31665
chenrujun merged 8 commits into
Azure:hotfix/spring-cloud-azure-4.4.1from
chenrujun:fix-bugs-caused-by-supporting-Azure-AD-proxy

Conversation

@chenrujun

@chenrujun chenrujun commented Oct 21, 2022

Copy link
Copy Markdown

@ghost ghost added the azure-spring All azure-spring related issues label Oct 21, 2022
@chenrujun chenrujun self-assigned this Oct 21, 2022
@chenrujun chenrujun added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. labels Oct 21, 2022
@chenrujun chenrujun added this to the 2022-11 milestone Oct 21, 2022
@chenrujun

chenrujun commented Oct 21, 2022

Copy link
Copy Markdown
Author

/azp run java - spring - ci

@chenrujun

chenrujun commented Oct 21, 2022

Copy link
Copy Markdown
Author

/azp run java - spring - tests

@azure-pipelines

azure-pipelines Bot commented Oct 21, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelines Bot commented Oct 21, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun

chenrujun commented Oct 21, 2022

Copy link
Copy Markdown
Author

Hi, @saragluna , @moarychan , please help review this PR when you have time.

@azure-sdk

azure-sdk commented Oct 21, 2022

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure

@chenrujun

chenrujun commented Oct 24, 2022

Copy link
Copy Markdown
Author

/azp run java - spring - ci

@chenrujun

chenrujun commented Oct 24, 2022

Copy link
Copy Markdown
Author

/azp run java - spring - tests

@azure-pipelines

azure-pipelines Bot commented Oct 24, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelines Bot commented Oct 24, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun

chenrujun commented Oct 24, 2022

Copy link
Copy Markdown
Author

/azp run java - spring - tests

@azure-pipelines

azure-pipelines Bot commented Oct 24, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun

chenrujun commented Oct 24, 2022

Copy link
Copy Markdown
Author

Hi, @saragluna , @moarychan , please help to review this PR.

@chenrujun

chenrujun commented Oct 24, 2022

Copy link
Copy Markdown
Author

The failure of java - code-quality-reports-ci can be ignored. Here is the detail information:

The java - code-quality-reports-ci#1938677 failed because the Revapi Maven Plugin checks the currently built project against the its latest released version (as reported by Maven). Current PR targeting to a patch release (4.4.1). The artifacts released new versions after 4.4.0, so comparing to latest released version will have error.

moarychan
moarychan approved these changes Oct 24, 2022
View reviewed changes

@moarychan moarychan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun
chenrujun merged commit 9348fc4 into Azure:hotfix/spring-cloud-azure-4.4.1 Oct 24, 2022
@chenrujun
chenrujun deleted the fix-bugs-caused-by-supporting-Azure-AD-proxy branch October 24, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moarychan moarychan moarychan approved these changes
@mssfang mssfang Awaiting requested review from mssfang
@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles
@backwind1233 backwind1233 Awaiting requested review from backwind1233
@hui1110 hui1110 Awaiting requested review from hui1110
@Netyyyy Netyyyy Awaiting requested review from Netyyyy
@saragluna saragluna Awaiting requested review from saragluna
@stliu stliu Awaiting requested review from stliu
@yiliuTo yiliuTo Awaiting requested review from yiliuTo
@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423

Assignees

@chenrujun chenrujun

Labels

azure-spring All azure-spring related issues bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.

Projects

Spring Cloud Azure
Status: Done

Milestone

2022-11

Development

Successfully merging this pull request may close these issues.

4 participants

@chenrujun @azure-sdk @moarychan @rujche