Skip to content

Issue 31716 no class def found error for com.nimbusds.jose.shaded.json.json array - #31743

Merged
chenrujun merged 4 commits into
Azure:mainfrom
chenrujun:issue_31716_NoClassDefFoundError_for_com.nimbusds.jose.shaded.json.JSONArray
Oct 28, 2022
Merged

Issue 31716 no class def found error for com.nimbusds.jose.shaded.json.json array#31743
chenrujun merged 4 commits into
Azure:mainfrom
chenrujun:issue_31716_NoClassDefFoundError_for_com.nimbusds.jose.shaded.json.JSONArray

Conversation

@chenrujun

@chenrujun chenrujun commented Oct 26, 2022

Copy link
Copy Markdown

Description

As title, Fix #31716

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the azure-spring All azure-spring related issues label Oct 26, 2022
@chenrujun chenrujun self-assigned this Oct 26, 2022
@chenrujun chenrujun added Client This issue points to a problem in the data-plane of the library. bug This issue requires a change to an existing behavior in the product in order to be resolved. labels Oct 26, 2022
@chenrujun chenrujun added this to the 2022-11 milestone Oct 26, 2022
@azure-sdk

azure-sdk commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@chenrujun

chenrujun commented Oct 26, 2022

Copy link
Copy Markdown
Author

Hi, @saragluna , @moarychan , please help to review this PR.

saragluna
saragluna approved these changes Oct 28, 2022
View reviewed changes

@saragluna saragluna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun chenrujun mentioned this pull request Oct 28, 2022
Merged
6 tasks
@chenrujun
chenrujun merged commit 91aa36c into Azure:main Oct 28, 2022
@saragluna saragluna mentioned this pull request Oct 28, 2022
Merged
@chenrujun
chenrujun deleted the issue_31716_NoClassDefFoundError_for_com.nimbusds.jose.shaded.json.JSONArray branch October 28, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saragluna saragluna saragluna approved these changes
@backwind1233 backwind1233 Awaiting requested review from backwind1233
@hui1110 hui1110 Awaiting requested review from hui1110
@Netyyyy Netyyyy Awaiting requested review from Netyyyy
@stliu stliu Awaiting requested review from stliu
@yiliuTo yiliuTo Awaiting requested review from yiliuTo
@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner
@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423

Assignees

@chenrujun chenrujun

Labels

azure-spring All azure-spring related issues bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.

Projects

Spring Cloud Azure
Status: Done

Milestone

2022-11

Development

Successfully merging this pull request may close these issues.

Autoconfigure's UserPrincipalManager should not import com.nimbusds.jose.shaded.json.JSONArray

5 participants

@chenrujun @azure-sdk @gueugaie @saragluna @rujche