Updated guava dependency throughout azure-cosmos - #31761
Merged
jeet1995 merged 23 commits intoNov 3, 2022
Merged
Conversation
kushagraThapar
requested review from
FabianMeiswinkel,
JonathanGiles,
Netyyyy,
aayush3011,
alzimmermsft,
backwind1233,
chenrujun,
fangjian0423,
g2vinay,
hui1110,
kirankumarkolli,
milismsft,
moarychan,
samvaity,
saragluna,
simorenoh,
stliu,
xinlian12 and
yiliuTo
as code owners
October 26, 2022 20:44
ghost
added
the
Member
Author
|
/azp run java - cosmos - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…b.com/kushagraThapar/azure-sdk-for-java into upgrade_guava_dependency_azure_cosmos
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
commented
Nov 2, 2022
anuchandy
approved these changes
Nov 3, 2022
kushagraThapar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR removes the dependency on the
guavalibrary due to possibility of recurring vulnerabilities (see CVE-2020-8908) and upgrades the dependency ontestnglibrary. As a result of moving away from theguavalibrary and vulnerabilities in thecommons-codeclibrary (see CVE-2020-15250) the murmur hash 3 implementation is shaded from thecommons-codeclibrary.Furthermore, the apache commons-codec implementation of murmur hash 3 is only used in unit testing and not in any implementation of azure-cosmos SDK.