Skip to content

Make UserPrincipalManager#getRoles more robust - #31803

Merged
chenrujun merged 1 commit into
Azure:mainfrom
chenrujun:issue_31716_NoClassDefFoundError_test-different-type
Oct 31, 2022
Merged

Make UserPrincipalManager#getRoles more robust#31803
chenrujun merged 1 commit into
Azure:mainfrom
chenrujun:issue_31716_NoClassDefFoundError_test-different-type

Conversation

@chenrujun

@chenrujun chenrujun commented Oct 28, 2022

Copy link
Copy Markdown

Description

Fix #31716. NoClassDefFoundError. Make UserPrincipalManager#getRoles more robust

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the azure-spring All azure-spring related issues label Oct 28, 2022
@chenrujun

chenrujun commented Oct 28, 2022

Copy link
Copy Markdown
Author

Hi, @saragluna , @moarychan , please help to review this PR.

@chenrujun chenrujun self-assigned this Oct 28, 2022
@chenrujun chenrujun added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. labels Oct 28, 2022
@chenrujun chenrujun added this to the 2022-11 milestone Oct 28, 2022
chenrujun referenced this pull request in chenrujun/azure-sdk-for-java Oct 28, 2022
@rujche
Fix Azure#31716. NoClassDefFoundError for com.nimbusds.jose.shaded.js…
4317ac9 
…on.JSONArray.
@azure-sdk

azure-sdk commented Oct 28, 2022

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

moarychan
moarychan approved these changes Oct 28, 2022
View reviewed changes

@moarychan moarychan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenrujun
chenrujun merged commit e7a8c6c into Azure:main Oct 31, 2022
@chenrujun
chenrujun deleted the issue_31716_NoClassDefFoundError_test-different-type branch October 31, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moarychan moarychan moarychan approved these changes
@backwind1233 backwind1233 Awaiting requested review from backwind1233
@hui1110 hui1110 Awaiting requested review from hui1110
@Netyyyy Netyyyy Awaiting requested review from Netyyyy
@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner
@stliu stliu Awaiting requested review from stliu
@yiliuTo yiliuTo Awaiting requested review from yiliuTo
@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423

Assignees

@chenrujun chenrujun

Labels

azure-spring All azure-spring related issues bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.

Projects

Spring Cloud Azure
Status: Done

Milestone

2022-11

Development

Successfully merging this pull request may close these issues.

Autoconfigure's UserPrincipalManager should not import com.nimbusds.jose.shaded.json.JSONArray

4 participants

@chenrujun @azure-sdk @moarychan @rujche