Skip to content

Adding default rule support for subscription creation - #31804

Merged
ki1729 merged 6 commits into
Azure:mainfrom
ki1729:krajasekar/sub_with_rule_v9
Oct 31, 2022
Merged

Adding default rule support for subscription creation#31804
ki1729 merged 6 commits into
Azure:mainfrom
ki1729:krajasekar/sub_with_rule_v9

Conversation

@ki1729

@ki1729 ki1729 commented Oct 28, 2022

Copy link
Copy Markdown
Contributor

Description

  • Adding default rule support to subscriptions. Today there is a gap from when a subscription is created , to when correct rules are configured when incorrect messages can get through. This addresses that gap.
  • This also fixes the issue of missing tests for sync admin client which caused a hotfix release. (Added Sync AdminClientIntegrationTests).

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-messaging-servicebus

@ki1729
ki1729 enabled auto-merge (squash) October 31, 2022 18:57
@ki1729
ki1729 requested review from anuchandy and conniey October 31, 2022 19:47

@anuchandy anuchandy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants