Change how List Blobs Perf Creates Blobs - #31817
Merged
alzimmermsft merged 10 commits intoNov 1, 2022
Merged
Conversation
ghost
added
Azure.Core
Collaborator
|
API change check API changes are not detected in this pull request. |
alzimmermsft
commented
Oct 28, 2022
| private static double getOperationsPerSecond(PerfTestBase<?>[] tests) { | ||
| return IntStream.range(0, tests.length) | ||
| .mapToDouble(i -> tests[i].getCompletedOperations() / (((double) tests[i].lastCompletionNanoTime) / NANOSECONDS_PER_SECOND)) | ||
| .sum(); |
Member
Author
There was a problem hiding this comment.
This had a fun issue where Double.NaN being added resulted in the value being Double.NaN.
alzimmermsft
marked this pull request as ready for review
October 28, 2022 20:32
alzimmermsft
requested review from
JonathanGiles,
anuchandy,
billwert,
ibrahimrabab,
jaschrep-msft,
lmolkova,
mssfang,
srnagar and
vcolin7
as code owners
October 28, 2022 20:32
ibrahimrabab
approved these changes
Oct 31, 2022
alzimmermsft
enabled auto-merge (squash)
November 1, 2022 16:19
mikeharder
added a commit
to mikeharder/azure-sdk-for-java
that referenced
this pull request
Nov 8, 2022
…changes to Perf Common (Azure#31817)" This partially reverts commit 906f0ad.
mikeharder
added a commit
to mikeharder/azure-sdk-for-java
that referenced
this pull request
Nov 8, 2022
… Perf Common (Azure#31817)" This reverts commit 906f0ad.
mikeharder
added a commit
to mikeharder/azure-sdk-for-java
that referenced
this pull request
Nov 8, 2022
… Perf Common (Azure#31817)" This reverts commit 906f0ad.
mikeharder
reviewed
Nov 10, 2022
| sink.complete(); | ||
| } | ||
| }) | ||
| .flatMap(ignored -> { |
Member
There was a problem hiding this comment.
Why do we need to check if the timer expired twice? The timer is approximate so running one extra operation should be fine. Returning a result of "0" won't increase completedOperations, but it will update lastCompletionNanoTime, which seems wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Another attempt at removing the need for
Schedulers.boundedElastic()inAysncRestProxy. The change stems from using logging in Reactor Netty to find that the same EPoll thread, in Linux, creates all connections to the Storage account. This may be from blob creation happening sequentially, making it parallel forces multiple EPoll threads to create the connections as multiple requests with happen at the same time making it impossible for one thread to create all connections.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines