Skip to content

Fixing range passed in for ShareFileRange - #31828

Merged
ibrahimrabab merged 5 commits into
Azure:mainfrom
ibrahimrabab:openInputStreamRange
Nov 1, 2022
Merged

Fixing range passed in for ShareFileRange#31828
ibrahimrabab merged 5 commits into
Azure:mainfrom
ibrahimrabab:openInputStreamRange

Conversation

@ibrahimrabab

Copy link
Copy Markdown
Contributor

Description

resolves #31524

When ShareFileRange was passed in a range of (startValue, endValue), instead of bytes read returning as the difference of end - start, number of bytes read returned as end value.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Oct 28, 2022
@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@alzimmermsft

Copy link
Copy Markdown
Member

We should add tests to this to ensure this doesn't break in the future

@ibrahimrabab
ibrahimrabab merged commit cde1d21 into Azure:main Nov 1, 2022
@ibrahimrabab
ibrahimrabab deleted the openInputStreamRange branch November 1, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ShareFileRange 'end' field not handled correctly when used with InputStream

3 participants