Fixing range passed in for ShareFileRange - #31828
Merged
Merged
Conversation
ibrahimrabab
requested review from
alzimmermsft and
jaschrep-msft
as code owners
October 28, 2022 23:03
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
|
We should add tests to this to ensure this doesn't break in the future |
alzimmermsft
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #31524
When ShareFileRange was passed in a range of (startValue, endValue), instead of bytes read returning as the difference of end - start, number of bytes read returned as end value.
All SDK Contribution checklist:
General Guidelines and Best Practices