Ensuring Websocket upgrade request's hostname is the same as the HTTP host, enabling HTTP Proxy for custom endpoint, and ensuring Proxy CONNECT request uses the actual front-end host. - #31829
Merged
Conversation
… host, enabling HTTP Proxy for custom endpoint, and ensuring Proxy CONNECT request uses the actual front-end host.
anuchandy
requested review from
JimSuplizio,
JonathanGiles,
alzimmermsft,
conniey,
g2vinay,
geagin,
haolingdong-msft,
ki1729,
liukun-msft,
samvaity,
srnagar and
weidongxu-microsoft
as code owners
October 28, 2022 23:37
ghost
added
Collaborator
|
API change check API changes are not detected in this pull request. |
conniey
reviewed
Oct 29, 2022
conniey
approved these changes
Oct 29, 2022
… to validate the connect hostname:port pair
Member
Author
|
The following cases with TransportType=AMQP_WEB_SOCKET are tested -
Where "host-header validation" means the host addressed by the custom endpoint is running in a mode that validates the host header. (See the below writeup for details). The test environment is documented here - https://gist.github.com/anuchandy/40c67c64f371f38f5ce5de4cd3a52dc5 |
liukun-msft
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31825 and #31826