Address UX study feedback - #31831
Merged
Merged
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
srnagar
reviewed
Oct 31, 2022
ki1729
enabled auto-merge (squash)
October 31, 2022 20:14
srnagar
approved these changes
Nov 1, 2022
| Objects.requireNonNull(dataCollectionRuleId, "'logs' cannot be null."); | ||
| String ruleId, String streamName, BinaryData logs, RequestOptions requestOptions) { | ||
| Objects.requireNonNull(ruleId, "'ruleId' cannot be null."); | ||
| Objects.requireNonNull(ruleId, "'streamName' cannot be null."); |
Member
There was a problem hiding this comment.
Suggested change
| Objects.requireNonNull(ruleId, "'streamName' cannot be null."); | |
| Objects.requireNonNull(streamName, "'streamName' cannot be null."); |
| String ruleId, String streamName, BinaryData logs, RequestOptions requestOptions) { | ||
| Objects.requireNonNull(ruleId, "'ruleId' cannot be null."); | ||
| Objects.requireNonNull(ruleId, "'streamName' cannot be null."); | ||
| Objects.requireNonNull(ruleId, "'logs' cannot be null."); |
Member
There was a problem hiding this comment.
Suggested change
| Objects.requireNonNull(ruleId, "'logs' cannot be null."); | |
| Objects.requireNonNull(logs, "'logs' cannot be null."); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed issues reported in #30859
Also made modifications based on recommendations from Arch board review , crew discussion.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines