Fixed servicebus default proxy configuration bug - #31832
Merged
ki1729 merged 2 commits intoOct 31, 2022
Merged
Conversation
ki1729
requested review from
anuchandy,
conniey,
geagin and
liukun-msft
as code owners
October 31, 2022 01:52
ghost
added
the
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
liukun-msft
approved these changes
Oct 31, 2022
liukun-msft
left a comment
liukun-msft
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Add the CHANGELOG for the fix?
liukun-msft
reviewed
Oct 31, 2022
| private ProxyOptions getDefaultProxyConfiguration(Configuration configuration) { | ||
| ProxyAuthenticationType authentication = ProxyAuthenticationType.NONE; | ||
| if (proxyOptions != null) { | ||
| authentication = proxyOptions.getAuthentication(); |
Contributor
There was a problem hiding this comment.
Information for other reviewers: here the authentication is never read correctly from the configuration. The correctly logic is moved to the ProxyOptions.fromConfiguration().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed #24230
All SDK Contribution checklist:
General Guidelines and Best Practices