Skip to content

Extend to 3 hours - #31867

Merged
sima-zhu merged 1 commit into
Azure:mainfrom
sima-zhu:extend-docindex-timeout
Nov 1, 2022
Merged

Extend to 3 hours#31867
sima-zhu merged 1 commit into
Azure:mainfrom
sima-zhu:extend-docindex-timeout

Conversation

@sima-zhu

@sima-zhu sima-zhu commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.
Java docindex validate and update package info once the version changes. We usually ran into traffic peak during the monthly release. Extend the pipeline to 3 hours to take care of the timeout.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1958961&view=results
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@sima-zhu
sima-zhu marked this pull request as ready for review November 1, 2022 19:39
@sima-zhu
sima-zhu requested review from danieljurek and weshaggard and removed request for JimSuplizio, benbp, hallipr and weshaggard November 1, 2022 19:39

@weshaggard weshaggard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok increasing the timeout as long as feel like there isn't any work we can cut out.

@sima-zhu

sima-zhu commented Nov 1, 2022

Copy link
Copy Markdown
Contributor Author

I'm ok increasing the timeout as long as feel like there isn't any work we can cut out.

The validation step takes time but lucky this only happens every month.

@sima-zhu
sima-zhu merged commit 140da1a into Azure:main Nov 1, 2022
@sima-zhu
sima-zhu deleted the extend-docindex-timeout branch November 1, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants