PopulateReplicaValidationFlagProperlyOnRequest - #32022
Merged
Merged
Conversation
xinlian12
requested review from
FabianMeiswinkel,
aayush3011,
jeet1995,
kirankumarkolli,
kushagraThapar,
milismsft and
simorenoh
as code owners
November 8, 2022 23:02
ghost
added
the
Collaborator
|
API change check API changes are not detected in this pull request. |
Pilchie
approved these changes
Nov 8, 2022
added 2 commits
November 8, 2022 15:18
kundadebdatta
self-requested a review
November 8, 2022 23:36
kushagraThapar
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Previously, the replica validation flag is not wired up correctly. It may cause request pick up replica in UnhealthyPending status.
Fix
Wire up the flag properly