Fixed unicode char handling in Uris in Cosmos Http Client - #32058
Merged
FabianMeiswinkel merged 18 commits intoNov 15, 2022
Merged
Conversation
…l for batch and bulk operations.
…to users/fabianm/throughputControlGroupNameBatchAndBulk
…to users/fabianm/slf4jCompiledAgain
…/FabianMeiswinkel/azure-sdk-for-java into users/fabianm/unicodeHandlingCosmosHttpClinet
FabianMeiswinkel
requested review from
Pilchie,
aayush3011,
jeet1995,
kirankumarkolli,
kushagraThapar,
milismsft,
simorenoh and
xinlian12
as code owners
November 10, 2022 00:06
ghost
added
the
xinlian12
reviewed
Nov 10, 2022
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
/azp run java - cosmos - tests |
Member
Author
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
approved these changes
Nov 10, 2022
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
FabianMeiswinkel
enabled auto-merge (squash)
November 11, 2022 20:16
Member
Author
|
/azp run java - cosmos - spark |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
Member
Author
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
…to users/fabianm/unicodeHandlingCosmosHttpClinet
Member
Author
|
/azp run java - cosmos - tests |
Member
Author
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cosmos Http client incorrectly uses URI.toString instead of URI.toASCIIString when constructing the Netty Http request - resulting in incorrect handling of Unicode chars in a Uri on the wire. Using URI.toASCIIString instead fixes this.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines