Skip to content

health insights sdk for java#33948

Merged
weidongxu-microsoft merged 29 commits into
Azure:mainfrom
asaflevi-ms:main
Mar 30, 2023
Merged

health insights sdk for java#33948
weidongxu-microsoft merged 29 commits into
Azure:mainfrom
asaflevi-ms:main

Conversation

@asaflevi-ms

Copy link
Copy Markdown
Member

Description

First PR for Health Insights - First Public preview

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@asaflevi-ms

Copy link
Copy Markdown
Member Author

/azp run prepare-pipelines

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@asaflevi-ms

Copy link
Copy Markdown
Member Author

Hi
@josefree , @srnagar , @anuchandy , @conniey , @lmolkova , @JonathanGiles
This is my first pr fro Health Insights (first public preview).
We are targeting public preview release end of March and would like to be ready as soon as possible for that release.
I will be happy to get your comments on this PR.
CADL PR: Azure/azure-rest-api-specs#22990

@JonathanGiles JonathanGiles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have APIView links we should also review?

Comment thread sdk/healthinsights/azure-health-insights-cancerprofiling/CHANGELOG.md Outdated
@asaflevi-ms

Copy link
Copy Markdown
Member Author

@weshaggard

Copy link
Copy Markdown
Member

@asaflevi-ms for my information how was this library generated? What steps did you use and what documentation did you reference?

@asaflevi-ms

Copy link
Copy Markdown
Member Author

@asaflevi-ms for my information how was this library generated? What steps did you use and what documentation did you reference?

Generated with Cadl: Azure/azure-rest-api-specs#22990

Used Cadl documentation and help from cadl/sdk support teams

@azure-sdk

azure-sdk commented Mar 15, 2023

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-health-insights-clinicalmatching
azure-health-insights-cancerprofiling

@weshaggard

Copy link
Copy Markdown
Member

Used Cadl documentation and help from cadl/sdk support teams

Could you provide a link to the docs you are using? I'm mostly trying to make sure we have the right docs for folks to be successful.

Comment thread sdk/healthinsights/azure-health-insights-cancerprofiling/src/samples/README.md Outdated
Comment thread sdk/healthinsights/azure-health-insights-cancerprofiling/src/samples/README.md Outdated
Comment thread sdk/healthinsights/azure-health-insights-cancerprofiling/README.md Outdated
Comment thread .vscode/cspell.json
Comment thread .vscode/cspell.json Outdated
Comment thread sdk/healthinsights/azure-health-insights-cancerprofiling/README.md Outdated
Comment thread sdk/healthinsights/azure-health-insights-cancerprofiling/README.md Outdated
Comment thread sdk/healthinsights/azure-health-insights-clinicalmatching/pom.xml
Comment thread sdk/healthinsights/azure-health-insights-clinicalmatching/src/samples/README.md Outdated
Comment thread sdk/healthinsights/azure-health-insights-clinicalmatching/README.md Outdated
@haolingdong-msft

Copy link
Copy Markdown
Member

Hi @asaflevi-ms , could you please also check the comments in the two API views?

@asaflevi-ms

Copy link
Copy Markdown
Member Author

Hi @asaflevi-ms , could you please also check the comments in the two API views?

Hi @haolingdong-msft ,
Sure, checked.

Comment thread sdk/healthinsights/ci.yml Outdated
@weidongxu-microsoft

Copy link
Copy Markdown
Member

@haolingdong-msft Could you make one final pass (and approve if you are good with it; I will do so as well)?

@haolingdong-msft

Copy link
Copy Markdown
Member

@haolingdong-msft Could you make one final pass (and approve if you are good with it; I will do so as well)?

Sure, I am checking.

@haolingdong-msft

Copy link
Copy Markdown
Member

LGTM, except this #33948 (comment), not sure if this is expected.

@asaflevi-ms

Copy link
Copy Markdown
Member Author

What is LGTM ?

@haolingdong-msft

Copy link
Copy Markdown
Member

What is LGTM ?

It means Looks good to me.

@weidongxu-microsoft weidongxu-microsoft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone has change request, please comment in PR.

I will merge it on 3/30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants