health insights sdk for java#33948
Conversation
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi |
JonathanGiles
left a comment
There was a problem hiding this comment.
Did you have APIView links we should also review?
|
@asaflevi-ms for my information how was this library generated? What steps did you use and what documentation did you reference? |
…s-sdk-for-java update cspell with missing words
Generated with Cadl: Azure/azure-rest-api-specs#22990 Used Cadl documentation and help from cadl/sdk support teams |
|
API change check APIView has identified API level changes in this PR and created following API reviews. azure-health-insights-clinicalmatching |
Could you provide a link to the docs you are using? I'm mostly trying to make sure we have the right docs for folks to be successful. |
|
Hi @asaflevi-ms , could you please also check the comments in the two API views? |
Hi @haolingdong-msft , |
|
@haolingdong-msft Could you make one final pass (and approve if you are good with it; I will do so as well)? |
Sure, I am checking. |
|
LGTM, except this #33948 (comment), not sure if this is expected. |
|
What is LGTM ? |
It means Looks good to me. |
weidongxu-microsoft
left a comment
There was a problem hiding this comment.
If anyone has change request, please comment in PR.
I will merge it on 3/30.
Description
First PR for Health Insights - First Public preview
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines