Skip to content

Add unassign job and update tests#34166

Merged
sarkar-rajarshi merged 9 commits into
mainfrom
cp/unassign-job
May 8, 2023
Merged

Add unassign job and update tests#34166
sarkar-rajarshi merged 9 commits into
mainfrom
cp/unassign-job

Conversation

@cparisineti

Copy link
Copy Markdown
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Communication label Mar 22, 2023
@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-jobrouter

@sarkar-rajarshi sarkar-rajarshi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Everything else looks good

@sarkar-rajarshi
sarkar-rajarshi merged commit a4f4d19 into main May 8, 2023
@sarkar-rajarshi
sarkar-rajarshi deleted the cp/unassign-job branch May 8, 2023 23:43
jairmyree pushed a commit to jairmyree/azure-sdk-for-java that referenced this pull request May 15, 2023
* Add unassign job and update tests

* Add javadocs

* Fix formatting errors

* More formatting fixes

* Fix liniting errors

* Remove field

* Commit session records

* Remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants