[Core-HttpClient-Matrix] Enable JDK and Vertx httpclient in pipeline.#34649
Conversation
mssfang
requested review from
JimSuplizio,
benbp,
hallipr and
weshaggard
as code owners
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - appconfiguration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
You'll need to update |
| { | ||
| "Agent": { | ||
| "ubuntu-20.04": { "OSVmImage": "MMSUbuntu20.04", "Pool": "azsdk-pool-mms-ubuntu-2004-general" } | ||
| }, | ||
| "JavaTestVersion": "1.17", | ||
| "AZURE_TEST_HTTP_CLIENTS": "jdk-httpclient", | ||
| "TestFromSource": true, | ||
| "RunAggregateReports": false, | ||
| "TestGoals": "verify", | ||
| "TestOptions": "-DskipCompile=true -DskipTestCompile=true -DcreateSourcesJar=false" | ||
| }, | ||
| { | ||
| "Agent": { | ||
| "windows-2022": { "OSVmImage": "windows-2022", "Pool": "azsdk-pool-mms-win-2022-general" } | ||
| }, | ||
| "JavaTestVersion": "1.17", | ||
| "AZURE_TEST_HTTP_CLIENTS": "jdk-httpclient", | ||
| "TestFromSource": false, | ||
| "RunAggregateReports": true, | ||
| "TestGoals": "verify", | ||
| "TestOptions": "-DskipCompile=true -DskipTestCompile=true -DcreateSourcesJar=false" | ||
| }, | ||
| { | ||
| "Agent": { | ||
| "ubuntu-20.04": { "OSVmImage": "MMSUbuntu20.04", "Pool": "azsdk-pool-mms-ubuntu-2004-general" } | ||
| }, | ||
| "JavaTestVersion": "1.17", | ||
| "AZURE_TEST_HTTP_CLIENTS": "jdk-httpclient", | ||
| "TestFromSource": false, | ||
| "RunAggregateReports": false, | ||
| "TestGoals": "surefire:test", | ||
| "TestOptions": "" |
There was a problem hiding this comment.
Do we need three of these runs? Could this be cut down to two additional runs of Linux and Windows? Right now, this change is adding 4 additional runs to live testing which is a lot more testing.
There was a problem hiding this comment.
Yeah. If it is time-consuming we can think to have testing Linux only if applies.
There was a problem hiding this comment.
There's also a cost/pipeline agent resourcing factor besides time.
|
/azp run java - appconfiguration - tests |
|
This PR will need to be reverted as this is causing live tests to fail that are configured to run with the https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2758798&view=results |
…ipeline. (Azure#34649)" This reverts commit 8ac808d.
…ipeline. (Azure#34649)" (Azure#34836) This reverts commit 8ac808d.
3 participants
Description
Enabling the JDK httpclient and Vertx httpclient in pipeline matrix