Skip to content

May eg events#34720

Merged
billwert merged 8 commits into
Azure:mainfrom
billwert:may-eg-events
May 8, 2023
Merged

May eg events#34720
billwert merged 8 commits into
Azure:mainfrom
billwert:may-eg-events

Conversation

@billwert

Copy link
Copy Markdown
Contributor

Add new Storage, ACS, and Healthcare events.
Move customization to a project.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@billwert
billwert requested review from alzimmermsft and removed request for lmolkova, mssfang and srnagar April 28, 2023 19:10
@billwert
billwert requested a review from srnagar April 28, 2023 19:10
@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-messaging-eventgrid

context-client-method-parameter: true
models-subpackage: systemevents
customization-class: EventGridCustomization
customization-class: src/main/java/EventGridCustomization.java

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should look into upgrading the use version to the latest of 4.1.17 and add some of the newer features such as

generic-response-type: true
disable-client-builder: true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look into it, but not here.

## 4.16.0-beta.1 (Unreleased)

### Features Added
- Added new events for Healthcare, Acs, and Storage.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ACS or Azure Communication Service instead of Acs.

@billwert
billwert merged commit 321b324 into Azure:main May 8, 2023
@billwert
billwert deleted the may-eg-events branch May 8, 2023 18:12
jairmyree pushed a commit to jairmyree/azure-sdk-for-java that referenced this pull request May 15, 2023
* New EventGrid events for May 2023

* move customization to its own project

* update changelog

* change constant name

* add to constant map

* update to post-archboard feedback.

* update URL to String

* Mechanical updates from autorest.java version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants