Skip to content

Update Schema Registry samples.#34799

Merged
conniey merged 6 commits into
Azure:mainfrom
conniey:schema-registry/forward-compat
May 5, 2023
Merged

Update Schema Registry samples.#34799
conniey merged 6 commits into
Azure:mainfrom
conniey:schema-registry/forward-compat

Conversation

@conniey

@conniey conniey commented May 5, 2023

Copy link
Copy Markdown
Member

Description

Updating samples to be more clear about usage with Event Hubs.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@conniey conniey requested a review from sjkwak as a code owner May 5, 2023 00:46
@conniey conniey self-assigned this May 5, 2023
@conniey conniey requested a review from srnagar as a code owner May 5, 2023 00:46
@azure-sdk

azure-sdk commented May 5, 2023

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

anuchandy
anuchandy approved these changes May 5, 2023
View reviewed changes

@anuchandy anuchandy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Comment thread .../com/azure/data/schemaregistry/apacheavro/SchemaRegistryApacheAvroDeserializationSample.java
Comment thread .../com/azure/data/schemaregistry/apacheavro/SchemaRegistryApacheAvroDeserializationSample.java Outdated
Comment thread ...o/src/samples/java/com/azure/data/schemaregistry/apacheavro/SchemaRegistryWithEventHubs.java Outdated
@conniey conniey merged commit 4ea5c88 into Azure:main May 5, 2023
@conniey conniey deleted the schema-registry/forward-compat branch May 5, 2023 07:11
jairmyree pushed a commit to jairmyree/azure-sdk-for-java that referenced this pull request May 15, 2023
@conniey @jairmyree
Update Schema Registry samples. (Azure#34799)
09c52b9 
* Update sample to show usage of EventData in deserialization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuchandy anuchandy anuchandy approved these changes
@sjkwak sjkwak Awaiting requested review from sjkwak sjkwak is a code owner
@srnagar srnagar Awaiting requested review from srnagar

Assignees

@conniey conniey

Labels

Schema Registry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@conniey @azure-sdk @anuchandy